From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>, xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH] x86: put vcpumask_to_pcpumask under CONFIG_PV
Date: Fri, 2 Nov 2018 19:30:43 +0000 [thread overview]
Message-ID: <9be8ae3b-fde9-f9ac-ffc1-6133f107653f@citrix.com> (raw)
In-Reply-To: <20181102192851.733-1-wei.liu2@citrix.com>
On 02/11/18 19:28, Wei Liu wrote:
> This function is used by PV code only. This issue is discovered by
> clang build.
Indeed. It is only used by two PV hypercalls.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> xen/arch/x86/mm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
> index f96678f46d..01ec6aa2bf 100644
> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -3057,6 +3057,7 @@ int new_guest_cr3(mfn_t mfn)
> #endif
> }
>
> +#ifdef CONFIG_PV
> static inline int vcpumask_to_pcpumask(
Mind dropping this spurious inline while you're at it?
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
> struct domain *d, XEN_GUEST_HANDLE_PARAM(const_void) bmap, cpumask_t *pmask)
> {
> @@ -3099,7 +3100,6 @@ static inline int vcpumask_to_pcpumask(
> }
> }
>
> -#ifdef CONFIG_PV
> static struct domain *get_pg_owner(domid_t domid)
> {
> struct domain *pg_owner = NULL, *curr = current->domain;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-11-02 19:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 19:28 [PATCH] x86: put vcpumask_to_pcpumask under CONFIG_PV Wei Liu
2018-11-02 19:30 ` Andrew Cooper [this message]
2018-11-05 10:26 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9be8ae3b-fde9-f9ac-ffc1-6133f107653f@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).