[PATCH] x86: put vcpumask_to_pcpumask under CONFIG_PV

[PATCH] x86: put vcpumask_to_pcpumask under CONFIG_PV

[Wei Liu]

This function is used by PV code only. This issue is discovered by
clang build.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 xen/arch/x86/mm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
index f96678f46d..01ec6aa2bf 100644
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -3057,6 +3057,7 @@ int new_guest_cr3(mfn_t mfn)
 #endif
 }
 
+#ifdef CONFIG_PV
 static inline int vcpumask_to_pcpumask(
     struct domain *d, XEN_GUEST_HANDLE_PARAM(const_void) bmap, cpumask_t *pmask)
 {
@@ -3099,7 +3100,6 @@ static inline int vcpumask_to_pcpumask(
     }
 }
 
-#ifdef CONFIG_PV
 static struct domain *get_pg_owner(domid_t domid)
 {
     struct domain *pg_owner = NULL, *curr = current->domain;
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] x86: put vcpumask_to_pcpumask under CONFIG_PV

[Andrew Cooper]

On 02/11/18 19:28, Wei Liu wrote:
> This function is used by PV code only. This issue is discovered by
> clang build.

Indeed.  It is only used by two PV hypercalls.

>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
>  xen/arch/x86/mm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
> index f96678f46d..01ec6aa2bf 100644
> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -3057,6 +3057,7 @@ int new_guest_cr3(mfn_t mfn)
>  #endif
>  }
>  
> +#ifdef CONFIG_PV
>  static inline int vcpumask_to_pcpumask(

Mind dropping this spurious inline while you're at it?

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

>      struct domain *d, XEN_GUEST_HANDLE_PARAM(const_void) bmap, cpumask_t *pmask)
>  {
> @@ -3099,7 +3100,6 @@ static inline int vcpumask_to_pcpumask(
>      }
>  }
>  
> -#ifdef CONFIG_PV
>  static struct domain *get_pg_owner(domid_t domid)
>  {
>      struct domain *pg_owner = NULL, *curr = current->domain;


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] x86: put vcpumask_to_pcpumask under CONFIG_PV

[Wei Liu]

On Fri, Nov 02, 2018 at 07:30:43PM +0000, Andrew Cooper wrote:
> On 02/11/18 19:28, Wei Liu wrote:
> > This function is used by PV code only. This issue is discovered by
> > clang build.
> 
> Indeed.  It is only used by two PV hypercalls.
> 
> >
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > ---
> >  xen/arch/x86/mm.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
> > index f96678f46d..01ec6aa2bf 100644
> > --- a/xen/arch/x86/mm.c
> > +++ b/xen/arch/x86/mm.c
> > @@ -3057,6 +3057,7 @@ int new_guest_cr3(mfn_t mfn)
> >  #endif
> >  }
> >  
> > +#ifdef CONFIG_PV
> >  static inline int vcpumask_to_pcpumask(
> 
> Mind dropping this spurious inline while you're at it?

Will do.

> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

Thanks.

> 
> >      struct domain *d, XEN_GUEST_HANDLE_PARAM(const_void) bmap, cpumask_t *pmask)
> >  {
> > @@ -3099,7 +3100,6 @@ static inline int vcpumask_to_pcpumask(
> >      }
> >  }
> >  
> > -#ifdef CONFIG_PV
> >  static struct domain *get_pg_owner(domid_t domid)
> >  {
> >      struct domain *pg_owner = NULL, *curr = current->domain;
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel