xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, Wei Liu <wei.liu2@citrix.com>,
	Jan Beulich <JBeulich@suse.com>,
	M A Young <m.a.young@durham.ac.uk>
Subject: Re: [PATCH] tools/xenstore: Add -Wno-bool-operation
Date: Wed, 5 Apr 2017 14:48:31 +0100	[thread overview]
Message-ID: <9bec9c0f-6dd2-15c1-6ecf-debd3b3f5ff9@citrix.com> (raw)
In-Reply-To: <08fb3d00-3463-dc0e-2d0a-49a5995ad885@citrix.com>

On 05/04/17 14:43, Andrew Cooper wrote:
> On 05/04/17 14:27, Ian Jackson wrote:
>> Andrew Cooper writes ("Re: [Xen-devel] [PATCH] tools/xenstore: Add -Wno-bool-operation"):
>>> I'm fairly sure this will break the Clang build.
>> This seems unlikely.
> Have you tried?

In an attempt to not be completely unhelpful in this situation,

xenstore_client.o xenstore_client.c
error: unknown warning option '-Wno-bool-operation'; did you mean
'-Wno-bool-conversion'? [-Werror,-Wunknown-warning-option]
/local/xen.git/tools/xenstore/../../tools/Rules.mk:212: recipe for
target 'xenstore_client.o' failed

>
>> I assume that clang has the same behaviour as gcc, for -Wno-unknown-warning.
> Have you tried?
>
> And independently of that,
>
> andrewcoop@andrewcoop:/local/xen.git/xen$ git grep unknown-warning -- :/
> andrewcoop@andrewcoop:/local/xen.git/xen$

 xenstore_client.o xenstore_client.c
error: unknown warning option '-Wno-unknown-warning'; did you mean
'-Wno-unknown-argument'? [-Werror,-Wunknown-warning-option]
/local/xen.git/tools/xenstore/../../tools/Rules.mk:212: recipe for
target 'xenstore_client.o' failed


This definitely breaks the clang build, and a GCC workaround don't help.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-04-05 13:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-29 15:05 Xen Security Advisory 206 - xenstore denial of service via repeated update Xen.org security team
2017-03-29 22:16 ` Michael Young
2017-03-31 17:00   ` Ian Jackson
2017-04-04 13:30     ` Ian Jackson
2017-04-05  7:44       ` M A Young
2017-04-05 13:12         ` Ian Jackson
2017-04-05 13:13           ` [PATCH] tools/xenstore: Add -Wno-bool-operation Ian Jackson
2017-04-05 13:24             ` Andrew Cooper
2017-04-05 13:27               ` Ian Jackson
2017-04-05 13:43                 ` Andrew Cooper
2017-04-05 13:48                   ` Andrew Cooper [this message]
2017-04-05 13:56                 ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9bec9c0f-6dd2-15c1-6ecf-debd3b3f5ff9@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=m.a.young@durham.ac.uk \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).