From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: boris.ostrovsky@oracle.com, xen-devel@lists.xen.org,
sherry.hurwitz@amd.com
Subject: Re: [PATCH v2] AMD IOMMU: Support IOAPIC IDs larger than 128
Date: Tue, 13 Dec 2016 07:14:58 +0700 [thread overview]
Message-ID: <9c1c0b52-9328-8b51-9a52-91b8b912a157@amd.com> (raw)
In-Reply-To: <584EC6550200007800128140@prv-mh.provo.novell.com>
On 12/12/16 21:46, Jan Beulich wrote:
>>>> On 05.12.16 at 20:36, <suravee.suthikulpanit@amd.com> wrote:
>> +unsigned int ioapic_id_to_index(unsigned int apic_id)
>> +{
>> + unsigned int idx;
>> +
>> + if ( !nr_ioapic_sbdf )
>> + return MAX_IO_APICS;
>
> This is pointless (redundant with ...
>
>> + for ( idx = 0 ; idx < nr_ioapic_sbdf; idx++ )
>> + if ( ioapic_sbdf[idx].id == apic_id )
>> + break;
>> +
>> + if ( idx == nr_ioapic_sbdf )
>> + return MAX_IO_APICS;
>
> ... this), so I think I'll take the liberty of removing it while committing.
> With that
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>
> And I see that you've got away without bumping the size of the
> array.
>
> Jan
>
Thanks Jan.
Suravee
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-12-13 0:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 19:36 [PATCH v2] AMD IOMMU: Support IOAPIC IDs larger than 128 Suravee Suthikulpanit
2016-12-12 14:46 ` Jan Beulich
2016-12-13 0:14 ` Suravee Suthikulpanit [this message]
2016-12-12 16:56 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c1c0b52-9328-8b51-9a52-91b8b912a157@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=JBeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=sherry.hurwitz@amd.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).