Re: [PATCH] tools/libxenforeignmemory: add a call to restrict the handle

[Julien Grall <julien.grall@arm.com>]

Hi Andre,

On 24/03/17 20:10, Andrew Cooper wrote:
> On 22/03/17 11:25, Paul Durrant wrote:
>> diff --git a/tools/libs/foreignmemory/libxenforeignmemory.map b/tools/libs/foreignmemory/libxenforeignmemory.map
>> index df206b3..5c9806c 100644
>> --- a/tools/libs/foreignmemory/libxenforeignmemory.map
>> +++ b/tools/libs/foreignmemory/libxenforeignmemory.map
>> @@ -4,5 +4,6 @@ VERS_1.0 {
>>  		xenforeignmemory_close;
>>  		xenforeignmemory_map;
>>  		xenforeignmemory_unmap;
>> +		xenforeignmemory_restrict;
>>  	local: *; /* Do not expose anything by default */
>>  };
>
> This isn't correct.
>
> New functions like this need to bump at least the SO minor version, like
> c/s f1446de4ba
>
> Fixing this is a blocker to releasing 4.9

I saw a patch (commit 9a7fbdd692) merged today to fix this. Let me know 
if there are more patches coming to address this.

>
> Also, we should really get automatic ABI checking built into the release
> process, to prevent mistakes like this from happening accidentally.

That's a good idea. I will create a task on Jira for that.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel