From: Olaf Hering <olaf@aepfle.de>
To: xen-devel@lists.xensource.com
Subject: [PATCH 16 of 18] tools/blktap2: fix build errors caused by Werror, remove blkif_op_name
Date: Fri, 30 Mar 2012 10:25:33 +0200 [thread overview]
Message-ID: <9dbadf67b1b76d5864d1.1333095933@probook.site> (raw)
In-Reply-To: <patchbomb.1333095917@probook.site>
# HG changeset patch
# User Olaf Hering <olaf@aepfle.de>
# Date 1333046917 -7200
# Node ID 9dbadf67b1b76d5864d1db715c1cda72cff53d16
# Parent af687dd9e9e0ebf3e68fd9413c027d0d0e8b7a33
tools/blktap2: fix build errors caused by Werror, remove blkif_op_name
-O2 -Wall -Werror triggers these warnings:
../include/blktaplib.h:235: warning: 'blkif_op_name' defined but not used
blkif_op_name[] is odd and appearently not used according to google, except in
an 7 years old blkdump.c which would not compile anyway with current blktap.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
diff -r af687dd9e9e0 -r 9dbadf67b1b7 tools/blktap2/include/blktaplib.h
--- a/tools/blktap2/include/blktaplib.h
+++ b/tools/blktap2/include/blktaplib.h
@@ -228,15 +228,4 @@ typedef struct msg_lock {
((_req) * BLKIF_MAX_SEGMENTS_PER_REQUEST * getpagesize()) + \
((_seg) * getpagesize()))
-/* Defines that are only used by library clients */
-
-#ifndef __COMPILING_BLKTAP_LIB
-
-static char *blkif_op_name[] = {
- [BLKIF_OP_READ] = "READ",
- [BLKIF_OP_WRITE] = "WRITE",
-};
-
-#endif /* __COMPILING_BLKTAP_LIB */
-
#endif /* __BLKTAPLIB_H__ */
next prev parent reply other threads:[~2012-03-30 8:25 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 8:25 [PATCH 00 of 18] tools: fix bugs and build errors triggered by -O2 -Wall -Werror Olaf Hering
2012-03-30 8:25 ` [PATCH 01 of 18] tools/blktap: fix access errors in convert_dev_name_to_num Olaf Hering
2012-04-02 13:47 ` Ian Jackson
2012-04-02 14:04 ` Ian Jackson
2012-04-02 14:42 ` Olaf Hering
2012-04-02 14:44 ` Olaf Hering
2012-04-02 15:04 ` Ian Campbell
2012-04-02 15:08 ` Olaf Hering
2012-04-02 15:16 ` Ian Jackson
2012-03-30 8:25 ` [PATCH 02 of 18] tools/blktap: fix params and physical-device parsing Olaf Hering
2012-04-02 14:38 ` Ian Jackson
2012-03-30 8:25 ` [PATCH 03 of 18] tools/blktap: fix access error in img2qcow.c Olaf Hering
2012-03-30 8:25 ` [PATCH 04 of 18] tools/blktap: fix access error in qcow2raw.c Olaf Hering
2012-03-30 8:25 ` [PATCH 05 of 18] tools/blktap2: fix build errors caused by Werror in vhd_journal_write_entry Olaf Hering
2012-04-02 13:55 ` Ian Jackson
2012-03-30 8:25 ` [PATCH 06 of 18] tools/blktap2: fix out of bounds access in block-log.c Olaf Hering
2012-04-02 14:31 ` Ian Jackson
2012-03-30 8:25 ` [PATCH 07 of 18] tools/blktap2: fix build errors caused by Werror in tdqcow_get_parent_id Olaf Hering
2012-04-02 13:52 ` Ian Jackson
2012-03-30 8:25 ` [PATCH 08 of 18] tools/blktap2: fix access error in img2qcow.c Olaf Hering
2012-03-30 8:25 ` [PATCH 09 of 18] tools/blktap2: fix access error in qcow2raw.c Olaf Hering
2012-03-30 8:25 ` [PATCH 10 of 18] tools/libvchan: fix build errors caused by -Werror in node-select.c Olaf Hering
2012-04-02 13:59 ` Ian Jackson
2012-04-02 14:40 ` Olaf Hering
2012-04-02 19:54 ` Olaf Hering
2012-04-03 8:23 ` Ian Campbell
2012-04-03 9:07 ` Olaf Hering
2012-04-03 10:27 ` Ian Jackson
2012-04-03 10:20 ` Ian Jackson
2012-03-30 8:25 ` [PATCH 11 of 18] tools/libxl: fix build errors caused by Werror in disk_eject_xswatch_callback Olaf Hering
2012-04-02 13:53 ` Ian Jackson
2012-04-02 19:58 ` Olaf Hering
2012-04-03 8:30 ` Ian Campbell
2012-04-03 9:11 ` Olaf Hering
2012-04-03 9:24 ` Ian Campbell
2012-04-03 10:28 ` Ian Jackson
2012-04-03 10:21 ` Ian Jackson
2012-03-30 8:25 ` [PATCH 12 of 18] tools/memshr: fix build errors caused by Werror Olaf Hering
2012-04-02 14:39 ` Ian Jackson
2012-03-30 8:25 ` [PATCH 13 of 18] tools/xenpaging: fix build errors caused by -Werror Olaf Hering
2012-04-02 14:01 ` Ian Jackson
2012-03-30 8:25 ` [PATCH 14 of 18] tools/libvchan: fix build errors caused by Werror in io.c Olaf Hering
2012-04-02 14:33 ` Ian Jackson
2012-04-02 14:37 ` Olaf Hering
2012-04-02 14:39 ` Ian Jackson
2012-03-30 8:25 ` [PATCH 15 of 18] tools/blktap2: remove static string table from header file Olaf Hering
2012-04-02 14:32 ` Ian Jackson
2012-03-30 8:25 ` Olaf Hering [this message]
2012-04-02 14:06 ` [PATCH 16 of 18] tools/blktap2: fix build errors caused by Werror, remove blkif_op_name Ian Jackson
2012-03-30 8:25 ` [PATCH 17 of 18] tools/blktap2: remove unused labels Olaf Hering
2012-04-02 14:32 ` Ian Jackson
2012-03-30 8:25 ` [PATCH 18 of 18] tools/blktap2: fix build errors caused by Werror, remove unused variables Olaf Hering
2012-03-30 12:44 ` Olaf Hering
-- strict thread matches above, loose matches on Subject: below --
2012-04-02 20:15 [PATCH 00 of 18] [v2] tools: fix bugs and build errors triggered by -O2 -Wall -Werror Olaf Hering
2012-04-02 20:15 ` [PATCH 16 of 18] tools/blktap2: fix build errors caused by Werror, remove blkif_op_name Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dbadf67b1b76d5864d1.1333095933@probook.site \
--to=olaf@aepfle.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).