From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH 2/3] xen: return xenstore command failures via response instead of rc Date: Thu, 22 Dec 2016 10:49:21 -0500 Message-ID: <9dc05fb2-cb84-d8e7-848b-37fb9c86b782@oracle.com> References: <20161222071948.23862-1-jgross@suse.com> <20161222071948.23862-3-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cK5cI-0004tw-Mu for xen-devel@lists.xenproject.org; Thu, 22 Dec 2016 15:49:14 +0000 In-Reply-To: <20161222071948.23862-3-jgross@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org T24gMTIvMjIvMjAxNiAwMjoxOSBBTSwgSnVlcmdlbiBHcm9zcyB3cm90ZToKPiBXaGVuIHRoZSB4 ZW5idXMgZHJpdmVyIGRvZXMgc29tZSBzcGVjaWFsIGhhbmRsaW5nIGZvciBhIFhlbnN0b3JlCj4g Y29tbWFuZCBhbnkgZXJyb3IgY29uZGl0aW9uIHJlbGF0ZWQgdG8gdGhlIGNvbW1hbmQgc2hvdWxk IGJlIHJldHVybmVkCj4gdmlhIGFuIGVycm9yIHJlc3BvbnNlIGluc3RlYWQgb2YgbGV0dGluZyB0 aGUgcmVsYXRlZCB3cml0ZSBvcGVyYXRpb24KPiBmYWlsLiBPdGhlcndpc2UgdGhlIHVzZXIgbGFu ZCBoYW5kbGVyIG1pZ2h0IHRha2Ugd3JvbmcgZGVjaXNpb25zCj4gYXNzdW1pbmcgdGhlIGNvbm5l Y3Rpb24gdG8gWGVuc3RvcmUgaXMgYnJva2VuLgoKRG8gd2UgZXhwZWN0IHRoZSB1c2VyIHRvIGFs d2F5cyByZWFkIHRoZSByZXBseSBpZiBubyBlcnJvciBjb2RlIHdhcwpyZXR1cm5lZD8KCi1ib3Jp cwoKPgo+IFdoaWxlIGF0IGl0IHRyeSB0byByZXR1cm4gdGhlIHNhbWUgZXJyb3IgdmFsdWVzIHhl bnN0b3JlZCB3b3VsZAo+IHJldHVybiBmb3IgdGhvc2UgY2FzZXMuCj4KPiBTaWduZWQtb2ZmLWJ5 OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+Cj4gLS0tCj4gIGRyaXZlcnMveGVuL3hl bmJ1cy94ZW5idXNfZGV2X2Zyb250ZW5kLmMgfCA0NyArKysrKysrKysrKysrKysrKystLS0tLS0t LS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjcgaW5zZXJ0aW9ucygrKSwgMjAgZGVsZXRpb25z KC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy94ZW4veGVuYnVzL3hlbmJ1c19kZXZfZnJvbnRl bmQuYyBiL2RyaXZlcnMveGVuL3hlbmJ1cy94ZW5idXNfZGV2X2Zyb250ZW5kLmMKPiBpbmRleCBh MDY4MjgxLi43OTEzMGIzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMveGVuL3hlbmJ1cy94ZW5idXNf ZGV2X2Zyb250ZW5kLmMKPiArKysgYi9kcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzX2Rldl9mcm9u dGVuZC5jCj4gQEAgLTMwMiw2ICszMDIsMjkgQEAgc3RhdGljIHZvaWQgd2F0Y2hfZmlyZWQoc3Ry dWN0IHhlbmJ1c193YXRjaCAqd2F0Y2gsCj4gIAltdXRleF91bmxvY2soJmFkYXAtPmRldl9kYXRh LT5yZXBseV9tdXRleCk7Cj4gIH0KPiAgCj4gK3N0YXRpYyBpbnQgeGVuYnVzX2NvbW1hbmRfcmVw bHkoc3RydWN0IHhlbmJ1c19maWxlX3ByaXYgKnUsCj4gKwkJCQl1bnNpZ25lZCBpbnQgbXNnX3R5 cGUsIGNvbnN0IGNoYXIgKnJlcGx5KQo+ICt7Cj4gKwlzdHJ1Y3Qgewo+ICsJCXN0cnVjdCB4c2Rf c29ja21zZyBoZHI7Cj4gKwkJY29uc3QgY2hhciBib2R5WzE2XTsKPiArCX0gbXNnOwo+ICsJaW50 IHJjOwo+ICsKPiArCW1zZy5oZHIgPSB1LT51Lm1zZzsKPiArCW1zZy5oZHIudHlwZSA9IG1zZ190 eXBlOwo+ICsJbXNnLmhkci5sZW4gPSBzdHJsZW4ocmVwbHkpICsgMTsKPiArCWlmIChtc2cuaGRy LmxlbiA+IHNpemVvZihtc2cuYm9keSkpCj4gKwkJcmV0dXJuIC1FMkJJRzsKPiArCj4gKwltdXRl eF9sb2NrKCZ1LT5yZXBseV9tdXRleCk7Cj4gKwlyYyA9IHF1ZXVlX3JlcGx5KCZ1LT5yZWFkX2J1 ZmZlcnMsICZtc2csIHNpemVvZihtc2cuaGRyKSArIG1zZy5oZHIubGVuKTsKPiArCXdha2VfdXAo JnUtPnJlYWRfd2FpdHEpOwo+ICsJbXV0ZXhfdW5sb2NrKCZ1LT5yZXBseV9tdXRleCk7Cj4gKwo+ ICsJcmV0dXJuIHJjOwo+ICt9Cj4gKwo+ICBzdGF0aWMgaW50IHhlbmJ1c193cml0ZV90cmFuc2Fj dGlvbih1bnNpZ25lZCBtc2dfdHlwZSwKPiAgCQkJCSAgICBzdHJ1Y3QgeGVuYnVzX2ZpbGVfcHJp diAqdSkKPiAgewo+IEBAIC0zMjEsNyArMzQ0LDcgQEAgc3RhdGljIGludCB4ZW5idXNfd3JpdGVf dHJhbnNhY3Rpb24odW5zaWduZWQgbXNnX3R5cGUsCj4gIAkJCWlmICh0cmFucy0+aGFuZGxlLmlk ID09IHUtPnUubXNnLnR4X2lkKQo+ICAJCQkJYnJlYWs7Cj4gIAkJaWYgKCZ0cmFucy0+bGlzdCA9 PSAmdS0+dHJhbnNhY3Rpb25zKQo+IC0JCQlyZXR1cm4gLUVTUkNIOwo+ICsJCQlyZXR1cm4geGVu YnVzX2NvbW1hbmRfcmVwbHkodSwgWFNfRVJST1IsICJFTk9FTlQiKTsKPiAgCX0KPiAgCj4gIAly ZXBseSA9IHhlbmJ1c19kZXZfcmVxdWVzdF9hbmRfcmVwbHkoJnUtPnUubXNnKTsKPiBAQCAtMzcy LDEyICszOTUsMTIgQEAgc3RhdGljIGludCB4ZW5idXNfd3JpdGVfd2F0Y2godW5zaWduZWQgbXNn X3R5cGUsIHN0cnVjdCB4ZW5idXNfZmlsZV9wcml2ICp1KQo+ICAJcGF0aCA9IHUtPnUuYnVmZmVy ICsgc2l6ZW9mKHUtPnUubXNnKTsKPiAgCXRva2VuID0gbWVtY2hyKHBhdGgsIDAsIHUtPnUubXNn Lmxlbik7Cj4gIAlpZiAodG9rZW4gPT0gTlVMTCkgewo+IC0JCXJjID0gLUVJTFNFUTsKPiArCQly YyA9IHhlbmJ1c19jb21tYW5kX3JlcGx5KHUsIFhTX0VSUk9SLCAiRUlOVkFMIik7Cj4gIAkJZ290 byBvdXQ7Cj4gIAl9Cj4gIAl0b2tlbisrOwo+ICAJaWYgKG1lbWNocih0b2tlbiwgMCwgdS0+dS5t c2cubGVuIC0gKHRva2VuIC0gcGF0aCkpID09IE5VTEwpIHsKPiAtCQlyYyA9IC1FSUxTRVE7Cj4g KwkJcmMgPSB4ZW5idXNfY29tbWFuZF9yZXBseSh1LCBYU19FUlJPUiwgIkVJTlZBTCIpOwo+ICAJ CWdvdG8gb3V0Owo+ICAJfQo+ICAKPiBAQCAtNDExLDIzICs0MzQsNyBAQCBzdGF0aWMgaW50IHhl bmJ1c193cml0ZV93YXRjaCh1bnNpZ25lZCBtc2dfdHlwZSwgc3RydWN0IHhlbmJ1c19maWxlX3By aXYgKnUpCj4gIAl9Cj4gIAo+ICAJLyogU3VjY2Vzcy4gIFN5bnRoZXNpemUgYSByZXBseSB0byBz YXkgYWxsIGlzIE9LLiAqLwo+IC0Jewo+IC0JCXN0cnVjdCB7Cj4gLQkJCXN0cnVjdCB4c2Rfc29j a21zZyBoZHI7Cj4gLQkJCWNoYXIgYm9keVszXTsKPiAtCQl9IF9fcGFja2VkIHJlcGx5ID0gewo+ IC0JCQl7Cj4gLQkJCQkudHlwZSA9IG1zZ190eXBlLAo+IC0JCQkJLmxlbiA9IHNpemVvZihyZXBs eS5ib2R5KQo+IC0JCQl9LAo+IC0JCQkiT0siCj4gLQkJfTsKPiAtCj4gLQkJbXV0ZXhfbG9jaygm dS0+cmVwbHlfbXV0ZXgpOwo+IC0JCXJjID0gcXVldWVfcmVwbHkoJnUtPnJlYWRfYnVmZmVycywg JnJlcGx5LCBzaXplb2YocmVwbHkpKTsKPiAtCQl3YWtlX3VwKCZ1LT5yZWFkX3dhaXRxKTsKPiAt CQltdXRleF91bmxvY2soJnUtPnJlcGx5X211dGV4KTsKPiAtCX0KPiArCXJjID0geGVuYnVzX2Nv bW1hbmRfcmVwbHkodSwgbXNnX3R5cGUsICJPSyIpOwo+ICAKPiAgb3V0Ogo+ICAJcmV0dXJuIHJj OwoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1k ZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54 ZW4ub3JnL3hlbi1kZXZlbAo=