From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Blake Subject: Re: [Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts Date: Thu, 19 Jan 2017 08:38:44 -0600 Message-ID: <9e16eb02-dc8b-b25f-0aba-d4a9ff3b5a02@redhat.com> References: <20170118161653.19296-1-eblake@redhat.com> <20170118161653.19296-3-eblake@redhat.com> <87lgu7flkc.fsf@dusky.pond.sub.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5107209542075111872==" Return-path: In-Reply-To: <87lgu7flkc.fsf@dusky.pond.sub.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Markus Armbruster Cc: Ronnie Sahlberg , Jeff Cody , qemu-devel@nongnu.org, Alexander Graf , Gerd Hoffmann , Stefano Stabellini , Alberto Garcia , "open list:Block layer core" , Michael Roth , Anthony Perard , Fam Zheng , Chrysostomos Nanakos , Stefan Weil , Peter Lieven , "Dr. David Alan Gilbert" , "open list:X86" , Stefan Hajnoczi , Richard Henderson , Kevin Wolf , "Richard W.M. Jones" , Max Reitz , Paolo Bonzini List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============5107209542075111872== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hd5Q7DSQCUvDaalKuHxxqcQDq2Wbj8oe6" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hd5Q7DSQCUvDaalKuHxxqcQDq2Wbj8oe6 Content-Type: multipart/mixed; boundary="wDgp30tlfi5srivFS90PHPmhWtpji5dBR"; protected-headers="v1" From: Eric Blake To: Markus Armbruster Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , Jeff Cody , Gerd Hoffmann , Stefano Stabellini , Alberto Garcia , "open list:Block layer core" , Alexander Graf , Anthony Perard , Fam Zheng , Michael Roth , Chrysostomos Nanakos , Stefan Weil , Peter Lieven , "Dr. David Alan Gilbert" , "open list:X86" , Ronnie Sahlberg , Richard Henderson , Kevin Wolf , "Richard W.M. Jones" , Max Reitz , Paolo Bonzini Message-ID: <9e16eb02-dc8b-b25f-0aba-d4a9ff3b5a02@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts References: <20170118161653.19296-1-eblake@redhat.com> <20170118161653.19296-3-eblake@redhat.com> <87lgu7flkc.fsf@dusky.pond.sub.org> In-Reply-To: <87lgu7flkc.fsf@dusky.pond.sub.org> --wDgp30tlfi5srivFS90PHPmhWtpji5dBR Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/19/2017 03:25 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> Quite a few users of qdict_put() were manually wrapping a >> non-QObject. We can make such call-sites shorter, by providing >> common macros to do the tedious work. Also shorten nearby >> qdict_put_obj(,,QOBJECT()) sequences. >> >> Signed-off-by: Eric Blake >> Reviewed-by: Alberto Garcia >> >> --- >> >> v2: rebase to current master >> >> I'm okay if you want me to break this patch into smaller pieces. >=20 > I guess I'm okay with a single piece, but I'd like to know how you did > the conversion. Coccinelle? Manually? Manual, via grepping for put_obj.*QOBJECT. I'll see if I can do the same under Coccinelle (at which point, committing the script will make it easier to rerun cleanups if later code reintroduces poor usage patterns), so maybe I have a v3 coming up. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --wDgp30tlfi5srivFS90PHPmhWtpji5dBR-- --hd5Q7DSQCUvDaalKuHxxqcQDq2Wbj8oe6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJYgM90AAoJEKeha0olJ0Nqtf4H/2XqUE1mZXeWEOPkUvvUvcAE oII7oXLCR+vwen9uxFWvu1czlz4D/IpCPLpYAJ07W5AUPGCUSGdwqnuG5zw7UpY2 KiEa7CUnMpbT5m5C3tQiMVz3kxFxtidV3UqZBj46dhz7cSv6KgqdaEz+vjF6vo8F i/D499hPlDAuyn4UlZ5HOO928BYPDO5PEz77wMgKTdFfld+lbIJ2bcckNDw59due YzpMDLKG8wQAZ3vQZPuV+feRLHvLAW1O1Grrhdsjg1N2bCuRbS9hPkaa3EE7N9Cw 1GABVRk9IE3c3vIc/GmScGFw30QSXQ045qrYVv/OSaaYhEEGFtiwgXdRf6RjQSA= =hK+R -----END PGP SIGNATURE----- --hd5Q7DSQCUvDaalKuHxxqcQDq2Wbj8oe6-- --===============5107209542075111872== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============5107209542075111872==--