Re: [PATCH] xen/arm64: Don't zero BSS when booting using EFI

[Julien Grall <julien.grall@arm.com>]

Hi Stefano,

On 03/02/17 19:14, Stefano Stabellini wrote:
> On Fri, 3 Feb 2017, Julien Grall wrote:
>> Hi Stefano,
>>
>> On 02/02/17 23:25, Stefano Stabellini wrote:
>>> On Thu, 2 Feb 2017, Julien Grall wrote:
>>>> ---
>>>>  xen/arch/arm/arm64/head.S | 23 +++++++++++++++++++----
>>>>  1 file changed, 19 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
>>>> index 3f63d2a..8cb4602 100644
>>>> --- a/xen/arch/arm/arm64/head.S
>>>> +++ b/xen/arch/arm/arm64/head.S
>>>> @@ -65,7 +65,7 @@
>>>>   *  x23 - UART address
>>>>   *  x24 - cpuid
>>>>   *  x25 - identity map in place
>>>> - *  x26 -
>>>> + *  x26 - skip_zero_bss
>>>>   *  x27 -
>>>>   *  x28 -
>>>>   *  x29 -
>>>> @@ -232,6 +232,10 @@ section_table:
>>>>          .long   0xe0500020       /* Characteristics (section flags) */
>>>>          .align  5
>>>>  real_start:
>>>> +        /* BSS should be zeroed when booting with efi */
>>>
>>> Do you mean "without"?
>>
>> Yes.
>>
>>>
>>> Aside from that:
>>>
>>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>>
>> Thank you! Regarding Jan's comment ([1]) I will let you decide if I should
>> update the comments.
>
> TBH I thought that all the "to avoid nasty surprises" messages are not
> very informative, so I think it would be better to improve them, but I
> don't feel strongly about it, up to you.

I will update the comments and send a new version next week.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel