xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Han-Lin Li <astercase@gmail.com>
To: xen-devel@lists.xensource.com
Subject: [PATCH] fix "Error flushing ioemu cache" message in xenpaging
Date: Wed, 15 Dec 2010 12:04:57 +0800	[thread overview]
Message-ID: <AANLkTi=o_pDNBoW1-qDZ_jtWOhmeWgJqBoqhDCUz371e@mail.gmail.com> (raw)

While using xenpaging, "Error flushing ioemu cache" message will be shown
on screen even if the "flush-cache" command is sent to xenstore correctly.
That is because xenpaging assume xc_mem_paging_flush_ioemu_cache()
return non-zero value when operation fail.  But
xc_mem_paging_flush_ioemu_cache() return the return value from xs_write()
which is zero when operation fail. So,  we should invert the return value from
xs_write() before use it as return value to prevent printing those
incorrect error messages.

---
Another problem is that the "flush-cache"  command isn't supported by
xenstore until you apply the patch below
http://thread.gmane.org/gmane.comp.emulators.xen.devel/91768/focus=91770
This patch isn't merged to unstable version yet.
Users need to merge this patch manually to make this function work correctly.
Anyone knows why this patch isn't merged to the unstable version?

---
Signed-off-by: Han-Lin Li <Han-Lin.Li@itri.org.tw>

diff -r 89116f28083f tools/xenpaging/xc.c
--- a/tools/xenpaging/xc.c      Wed Dec 08 10:46:31 2010 +0000
+++ b/tools/xenpaging/xc.c      Wed Dec 15 19:23:53 2010 +0800
@@ -62,7 +62,7 @@
     xs_daemon_close(xsh);
-    return rc;
+    return !rc;
 }
 int xc_wait_for_event_or_timeout(xc_interface *xch, int xce_handle,
unsigned long ms)

             reply	other threads:[~2010-12-15  4:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-15  4:04 Han-Lin Li [this message]
2011-01-06 17:43 ` [PATCH] fix "Error flushing ioemu cache" message in xenpaging Ian Jackson
2011-01-10 10:29   ` Olaf Hering
2011-01-11 16:48     ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=o_pDNBoW1-qDZ_jtWOhmeWgJqBoqhDCUz371e@mail.gmail.com' \
    --to=astercase@gmail.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).