[PATCH] fix "Error flushing ioemu cache" message in xenpaging

[PATCH] fix "Error flushing ioemu cache" message in xenpaging

[Han-Lin Li]

While using xenpaging, "Error flushing ioemu cache" message will be shown
on screen even if the "flush-cache" command is sent to xenstore correctly.
That is because xenpaging assume xc_mem_paging_flush_ioemu_cache()
return non-zero value when operation fail.  But
xc_mem_paging_flush_ioemu_cache() return the return value from xs_write()
which is zero when operation fail. So,  we should invert the return value from
xs_write() before use it as return value to prevent printing those
incorrect error messages.

---
Another problem is that the "flush-cache"  command isn't supported by
xenstore until you apply the patch below
http://thread.gmane.org/gmane.comp.emulators.xen.devel/91768/focus=91770
This patch isn't merged to unstable version yet.
Users need to merge this patch manually to make this function work correctly.
Anyone knows why this patch isn't merged to the unstable version?

---
Signed-off-by: Han-Lin Li <Han-Lin.Li@itri.org.tw>

diff -r 89116f28083f tools/xenpaging/xc.c
--- a/tools/xenpaging/xc.c      Wed Dec 08 10:46:31 2010 +0000
+++ b/tools/xenpaging/xc.c      Wed Dec 15 19:23:53 2010 +0800
@@ -62,7 +62,7 @@
     xs_daemon_close(xsh);
-    return rc;
+    return !rc;
 }
 int xc_wait_for_event_or_timeout(xc_interface *xch, int xce_handle,
unsigned long ms)

Re: [PATCH] fix "Error flushing ioemu cache" message in xenpaging

[Ian Jackson]

Han-Lin Li writes ("[Xen-devel] [PATCH] fix "Error flushing ioemu cache" message in xenpaging"):
> While using xenpaging, "Error flushing ioemu cache" message will be shown
> on screen even if the "flush-cache" command is sent to xenstore correctly.
> That is because xenpaging assume xc_mem_paging_flush_ioemu_cache()
> return non-zero value when operation fail.  But
> xc_mem_paging_flush_ioemu_cache() return the return value from xs_write()
> which is zero when operation fail. So,  we should invert the return value from
> xs_write() before use it as return value to prevent printing those
> incorrect error messages.

I'd like to give Olaf Hering a chance to respond, though, as it seems
he hasn't already.

Perhaps xc_mem_paging_flush_ioemu_cache ought to return -1 on error
and 0 on success, like most other xc functions ?

Thanks,
Ian.

> 
> ---
> Signed-off-by: Han-Lin Li <Han-Lin.Li@itri.org.tw>
> 
> diff -r 89116f28083f tools/xenpaging/xc.c
> --- a/tools/xenpaging/xc.c      Wed Dec 08 10:46:31 2010 +0000
> +++ b/tools/xenpaging/xc.c      Wed Dec 15 19:23:53 2010 +0800
> @@ -62,7 +62,7 @@
>      xs_daemon_close(xsh);
> -    return rc;
> +    return !rc;
>  }
>  int xc_wait_for_event_or_timeout(xc_interface *xch, int xce_handle,
> unsigned long ms)
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
> 

Re: [PATCH] fix "Error flushing ioemu cache" message in xenpaging

[Olaf Hering]

On Thu, Jan 06, Ian Jackson wrote:

> Han-Lin Li writes ("[Xen-devel] [PATCH] fix "Error flushing ioemu cache" message in xenpaging"):
> > While using xenpaging, "Error flushing ioemu cache" message will be shown
> > on screen even if the "flush-cache" command is sent to xenstore correctly.
> > That is because xenpaging assume xc_mem_paging_flush_ioemu_cache()
> > return non-zero value when operation fail.  But
> > xc_mem_paging_flush_ioemu_cache() return the return value from xs_write()
> > which is zero when operation fail. So,  we should invert the return value from
> > xs_write() before use it as return value to prevent printing those
> > incorrect error messages.
> 
> I'd like to give Olaf Hering a chance to respond, though, as it seems
> he hasn't already.

I see these harmless error messages as well, but havent looked at the
root cause yet.

> Perhaps xc_mem_paging_flush_ioemu_cache ought to return -1 on error
> and 0 on success, like most other xc functions ?

Like 'return rc ? 0 : -1;'?
Either way is fine with me.

Olaf

> > ---
> > Signed-off-by: Han-Lin Li <Han-Lin.Li@itri.org.tw>
> > 
> > diff -r 89116f28083f tools/xenpaging/xc.c
> > --- a/tools/xenpaging/xc.c      Wed Dec 08 10:46:31 2010 +0000
> > +++ b/tools/xenpaging/xc.c      Wed Dec 15 19:23:53 2010 +0800
> > @@ -62,7 +62,7 @@
> >      xs_daemon_close(xsh);
> > -    return rc;
> > +    return !rc;
> >  }
> >  int xc_wait_for_event_or_timeout(xc_interface *xch, int xce_handle,
> > unsigned long ms)
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xensource.com
> > http://lists.xensource.com/xen-devel
> > 

Re: [PATCH] fix "Error flushing ioemu cache" message in xenpaging

[Ian Jackson]

Olaf Hering writes ("Re: [Xen-devel] [PATCH] fix "Error flushing ioemu cache" message in xenpaging"):
> Like 'return rc ? 0 : -1;'?
> Either way is fine with me.

Right, that's what I meant.  Thanks.  I have applied  rc ? 0 : -1.

Ian.