From mboxrd@z Thu Jan 1 00:00:00 1970 From: eXeC001er Subject: Re: [PATCH] Re: blktap2 problem with pvops kernel 2.6.32.13 and xen 4.0-rc1 Date: Mon, 31 May 2010 14:27:41 +0400 Message-ID: References: <779292.12969.qm@web56107.mail.re3.yahoo.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0119107846==" Return-path: In-Reply-To: <779292.12969.qm@web56107.mail.re3.yahoo.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Boris Derzhavets Cc: Xen-devel , Keir Fraser List-Id: xen-devel@lists.xenproject.org --===============0119107846== Content-Type: multipart/alternative; boundary=0016365eea087dc3800487e14e6b --0016365eea087dc3800487e14e6b Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Patch for xen-unstable.hg 2010/5/31 Boris Derzhavets > I've attempted to process patch for xen-4.0.0-0.7.f12.src.rpm it gives an > errors. > Is it written for xen 4.0 ? I did some manual check . > > Boris. > > > --- On *Sun, 5/30/10, eXeC001er * wrote: > > > From: eXeC001er > Subject: Re: [Xen-devel] [PATCH] Re: blktap2 problem with pvops kernel > 2.6.32.13 and xen 4.0-rc1 > To: "Keir Fraser" > Cc: "Boris Derzhavets" , "Xen-devel" < > xen-devel@lists.xensource.com> > Date: Sunday, May 30, 2010, 11:00 AM > > > this patch remove problems with blktap2 devices: > 1. If we use blktap2 disk device then DomU does not boot. Returned error:= File > 'vhd:/path/.../disk.img' doesn't exist. > 2. Created blktap2 disk device does not accessible immediately after > connecting: If we use pygrub then DomU does not boot. Returned error: Dis= k > is not accessible. > > Signed-off-by: eXeC001er > > > --- > > 2010/5/30 Keir Fraser > > > >> Needs a patch description and a signed-off-by line. >> >> -- Keir >> >> On 30/05/2010 13:21, "eXeC001er" > >> wrote: >> >> > My python-experience is small, but i tied to rewrite. >> > New in attach. >> > >> > 2010/5/30 Keir Fraser >> > >> >> On 30/05/2010 11:37, "Pasi K=C3=A4rkk=C3=A4inen" > >> wrote: >> >> >> >>> On Sun, May 30, 2010 at 02:02:06PM +0400, eXeC001er wrote: >> >>>> I have already sent a patch 1 weak ago. >> (blktap2_control_func.patch) >> >>>> repeat in attach. >> >>>> Thanks. >> >>> >> >>> Ok, thanks. >> >>> >> >>> Keir: I guess this is not committed yet? >> >> >> >> I'm not too happy about the sleep(5). I guess if there's no better >> solution >> >> coming up I should just whack this patch in? >> >> >> >> -- Keir >> >> >> >>> -- Pasi >> >>> >> >>>> 2010/5/30 Pasi K=C3=A4rkk=C3=A4inen <[1]pasik@iki.fi >> > >> >>>> >> >>>> On Sun, May 30, 2010 at 11:17:51AM +0400, eXeC001er wrote: >> >>>>> I've attempted to install Nexenta Core 3 image under Xen 4.0 >> >>>> (2.6.32.13 >> >>>>> pvops) on top of F13. Sample nexenta3.cfg profile contains 4 >> >>>> lines like >> >>>>> this:- >> >>>>> >> >>>>> disk=3D['tat:tapdisk:vhd:/path/../disk.img,xvda,w'] ( from >> sample) >> >>>>> >> >>>>> It generates message >> >>>>> =C3=82 File 'vhd:/path/.../disk.img' doesn't exist. >> >>>>> >> >>>>> Boris. >> >>>>> P.S. It was already in one of the threads @xen-users. >> >>>>> >> >>>>> This bug in "def _parse_uname(uname):" >> >>>> (tools/python/xen/util/blkif.py) >> >>>>> (taptype, fn) =3D fn.split(":", 1) >>>>>>=C3=82 (taptype, fn) = =3D >> >>>> fn.split(":", >> >>>>> 2)[1:3] >> >>>> >> >>>> Can you send a proper patch, as unified diff (diff -u), with a >> >>>> Signed-off-by line? >> >>>> -- Pasi >> >>>> >> >>>> References >> >>>> >> >>>> Visible links >> >>>> 1. mailto:pasik@iki.fi >> >>> >> >>>> diff -r d0420ab97345 tools/python/xen/util/blkif.py >> >>>> --- a/tools/python/xen/util/blkif.py Fri May 21 16:21:39 2010 +0100 >> >>>> +++ b/tools/python/xen/util/blkif.py Sat May 22 01:21:15 2010 +0400 >> >>>> @@ -87,7 +87,7 @@ >> >>>> fn =3D "/dev/%s" %(fn,) >> >>>> >> >>>> if typ in ("tap", "tap2"): >> >>>> - (taptype, fn) =3D fn.split(":", 1) >> >>>> + (taptype, fn) =3D fn.split(":", 2)[1:] >> >>>> return (fn, taptype) >> >>>> >> >>>> def blkdev_uname_to_file(uname): >> >>>> diff -r d0420ab97345 tools/python/xen/xend/XendDomainInfo.py >> >>>> --- a/tools/python/xen/xend/XendDomainInfo.py Fri May 21 16:21:39 >> 2010 >> >>>> +0100 >> >>>> +++ b/tools/python/xen/xend/XendDomainInfo.py Sat May 22 01:21:15 >> 2010 >> >>>> +0400 >> >>>> @@ -3292,6 +3292,7 @@ >> >>>> fn =3D BOOTLOADER_LOOPBACK_DEVICE >> >>>> >> >>>> try: >> >>>> + time.sleep(5) >> >>>> blcfg =3D bootloader(blexec, fn, self, False, >> >>>> bootloader_args, kernel, ramdis= k, >> args) >> >>>> finally: >> >>>> @@ -3299,7 +3300,7 @@ >> >>>> log.info ("Unmounting %s fro= m >> %s." % >> >>>> (fn, BOOTLOADER_LOOPBACK_DEVICE)) >> >>>> >> >>>> - dom0.destroyDevice('tap', >> BOOTLOADER_LOOPBACK_DEVICE) >> >>>> + dom0.destroyDevice(devtype, >> >>>> BOOTLOADER_LOOPBACK_DEVICE) >> >>>> >> >>>> if blcfg is None: >> >>>> msg =3D "Had a bootloader specified, but can't fin= d >> disk" >> >>> >> >> >> >> >> > >> > >> >> >> > > -----Inline Attachment Follows----- > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel > > > --0016365eea087dc3800487e14e6b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Patch for xen-unstable.hg

2010/5/31 Boris= Derzhavets <= bderzhavets@yahoo.com>
I've attempted to process patch for x= en-4.0.0-0.7.f12.src.rpm it gives an errors.
Is it written for xen 4.0 ?= =C2=A0 I did some manual check .

Boris.


--- On Sun, 5/30/10, eXeC001er <execooler@gmail.com> wrote:

From: eXeC001er <execooler@gmail.com>
Subject: Re: [Xen-devel] [PATCH] Re: b= lktap2 problem with pvops kernel 2.6.32.13 and xen 4.0-rc1
To: "Ke= ir Fraser" <keir.fraser@eu.citrix.com>
Cc: "Boris Derzhavets" <bderzhavets@yahoo.com>, "Xen-devel" &= lt;xen-d= evel@lists.xensource.com>
Date: Sunday, May 30, 2010, 11:00 AM

<= br>
this patch remove problems with blktap2 de= vices:
1. If we use blktap2 disk device then DomU does not boot. Re= turned error:=C2=A0File 'vhd:/path/.../disk.img' doesn't= exist.
2. Created blktap2 disk device does not accessible=C2=A0immediately after connecting: I= f we use pygrub then DomU does not boot. Returned error: Disk is not access= ible.

Signed-off-b= y: eXeC001er <execooler@gmail.com>
---
2010/5/30 Keir Fraser <keir.frase= r@eu.citrix.com>
Needs a patch description and a signed-off-by line.

=C2=A0-- Keir

On 30/05/2010 13:21, "eXeC001er" <execooler@gma= il.com> wrote:

> My python-experience=C2=A0is small, but i tied to rewrite.
> New in attach.
>
> 2010/5/30 Keir Fraser <keir.fraser@eu.citrix.c= om>
>> On 30/05/2010 11:37, "Pasi K=C3=A4rkk=C3=A4inen" <pasik@iki.fi> wrote:
>>
>>> On Sun, May 30, 2010 at 02:02:06PM +0400, eXeC001er wrote:
>>>> =C2=A0 =C2=A0I have already sent a patch 1 weak ago. (blkt= ap2_control_func.patch)
>>>> =C2=A0 =C2=A0repeat in attach.
>>>> =C2=A0 =C2=A0Thanks.
>>>
>>> Ok, thanks.
>>>
>>> Keir: I guess this is not committed yet?
>>
>> I'm not too happy about the sleep(5). I guess if there's n= o better solution
>> coming up I should just whack this patch in?
>>
>> =C2=A0-- Keir
>>
>>> -- Pasi
>>>
>>>> =C2=A0 =C2=A02010/5/30 Pasi K=C3=A4rkk=C3=A4inen <[1]pasik@iki.fi>
>>>>
>>>> =C2=A0 =C2=A0 =C2=A0On Sun, May 30, 2010 at 11:17:51AM +04= 00, eXeC001er wrote:
>>>>> =C2=A0 =C2=A0 =C2=A0I've attempted to install Nexe= nta Core 3 image under Xen 4.0
>>>> =C2=A0 =C2=A0 =C2=A0(2.6.32.13
>>>>> =C2=A0 =C2=A0 =C2=A0pvops) on top of F13. Sample nexen= ta3.cfg profile contains 4
>>>> =C2=A0 =C2=A0 =C2=A0lines like
>>>>> =C2=A0 =C2=A0 =C2=A0this:-
>>>>>
>>>>> =C2=A0 =C2=A0 =C2=A0disk=3D['tat:tapdisk:vhd:/path= /../disk.img,xvda,w'] ( from sample)
>>>>>
>>>>> =C2=A0 =C2=A0 =C2=A0It generates message
>>>>> =C2=A0 =C2=A0 =C2=A0=C3=82 File 'vhd:/path/.../dis= k.img' doesn't exist.
>>>>>
>>>>> =C2=A0 =C2=A0 =C2=A0Boris.
>>>>> =C2=A0 =C2=A0 =C2=A0P.S. It was already in one of the = threads @xen-users.
>>>>>
>>>>> =C2=A0 =C2=A0This bug in "def _parse_uname(uname)= :"
>>>> =C2=A0 =C2=A0 =C2=A0(tools/python/xen/util/blkif.py)
>>>>> =C2=A0 =C2=A0(taptype, fn) =3D fn.split(":",= 1) >>>>>>=C3=82 (taptype, fn) =3D
>>>> =C2=A0 =C2=A0 =C2=A0fn.split(":",
>>>>> =C2=A0 =C2=A02)[1:3]
>>>>
>>>> =C2=A0 =C2=A0 =C2=A0Can you send a proper patch, as unifie= d diff (diff -u), with a
>>>> =C2=A0 =C2=A0 =C2=A0Signed-off-by line?
>>>> =C2=A0 =C2=A0 =C2=A0-- Pasi
>>>>
>>>> References
>>>>
>>>> =C2=A0 =C2=A0Visible links
>>>> =C2=A0 =C2=A01. mailto:pasik@iki.fi
>>>
>>>> diff -r d0420ab97345 tools/python/xen/util/blkif.py
>>>> --- a/tools/python/xen/util/blkif.py Fri May 21 16:21:39 2= 010 +0100
>>>> +++ b/tools/python/xen/util/blkif.py Sat May 22 01:21:15 2= 010 +0400
>>>> @@ -87,7 +87,7 @@
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0fn =3D "/dev/%s" %(fn,)
>>>>
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if typ in ("tap&quo= t;, "tap2"):
>>>> - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(taptype, fn) = =3D fn.split(":", 1)
>>>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(taptype, fn) = =3D fn.split(":", 2)[1:]
>>>> =C2=A0 =C2=A0 =C2=A0return (fn, taptype)
>>>>
>>>> =C2=A0def blkdev_uname_to_file(uname):
>>>> diff -r d0420ab97345 tools/python/xen/xend/XendDomainInfo.= py
>>>> --- a/tools/python/xen/xend/XendDomainInfo.py Fri May 21 1= 6:21:39 2010
>>>> +0100
>>>> +++ b/tools/python/xen/xend/XendDomainInfo.py Sat May 22 0= 1:21:15 2010
>>>> +0400
>>>> @@ -3292,6 +3292,7 @@
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0fn =3D BOOTLOADER_LOOPBACK_DEVICE
>>>>
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0try:
>>>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0t= ime.sleep(5)
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0blcfg =3D bootloader(blexec, fn, self, False,
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 bootl= oader_args, kernel, ramdisk, args)
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0finally: >>>> @@ -3299,7 +3300,7 @@
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0log.info <http://log.info> ("Unmounting %s from %= s." %
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (fn, = BOOTLOADER_LOOPBACK_DEVICE))
>>>>
>>>> - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0dom0.destroyDevice('tap', BOOTLOADER_LOOPBACK_DEVICE)<= br> >>>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0dom0.destroyDevice(devtype,
>>>> BOOTLOADER_LOOPBACK_DEVICE)
>>>>
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if blcfg i= s None:
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0msg =3D "Had a bootloader specified, but can't find disk&quo= t;
>>>
>>
>>
>
>




-----Inline Attachment Follows-----
=

_______________________________________________
Xen-devel m= ailing list
Xen-devel@lists.xensource.com
http://l= ists.xensource.com/xen-devel


--0016365eea087dc3800487e14e6b-- --===============0119107846== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============0119107846==--