From: Frank Pan <frankpzh@gmail.com>
To: xen-devel@lists.xensource.com,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Jeremy Fitzhardinge <Jeremy.Fitzhardinge@citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>
Subject: [PATCH pvops] Fix a bug that shutdown watcher is disabled on pvops
Date: Fri, 4 Mar 2011 00:46:20 +0800 [thread overview]
Message-ID: <AANLkTikUyYpVKG_LZHFLL-ziCfU-Oc3qM9uFCd7QH13Z@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]
I use pvops kernel for HVM domU, and I find that shutdown watcher is
not enabled at all when I compile platform-pci module inside kernel.
The code related calls xen_setup_shutdown_event after xenbus_probe,
that makes setup_shutdown_watcher never called.
The following patch fixes this by changing the order of xenbus_probe
and xen_setup_shutdown, which makes my PV-on-HVM domU responses well
for the "control/shutdown" entry.
---
linux-2.6-xen/drivers/xen/platform-pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/linux-2.6-xen/drivers/xen/platform-pci.c
b/linux-2.6-xen/drivers/xen/platform-pci.c
index c01b5dd..f141cfe 100644
--- a/linux-2.6-xen/drivers/xen/platform-pci.c
+++ b/linux-2.6-xen/drivers/xen/platform-pci.c
@@ -162,10 +162,10 @@ static int __devinit platform_pci_init(struct
pci_dev *pdev,
ret = gnttab_init();
if (ret)
goto out;
- xenbus_probe(NULL);
ret = xen_setup_shutdown_event();
if (ret)
goto out;
+ xenbus_probe(NULL);
return 0;
out:
--
1.7.0.4
--
Frank Pan
Computer Science and Technology
Tsinghua University
[-- Attachment #2: 0001-Fix-a-bug-that-shutdown-watcher-is-disabled-on-pvops.patch --]
[-- Type: text/x-patch, Size: 811 bytes --]
From 8d2402bd48ccc9eb5afe2aaa407d61ff715cb24c Mon Sep 17 00:00:00 2001
From: Frank Pan <frankpzh@gmail.com>
Date: Thu, 3 Mar 2011 16:36:17 +0000
Subject: [PATCH] Fix a bug that shutdown watcher is disabled on pvops
---
linux-2.6-xen/drivers/xen/platform-pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/linux-2.6-xen/drivers/xen/platform-pci.c b/linux-2.6-xen/drivers/xen/platform-pci.c
index c01b5dd..f141cfe 100644
--- a/linux-2.6-xen/drivers/xen/platform-pci.c
+++ b/linux-2.6-xen/drivers/xen/platform-pci.c
@@ -162,10 +162,10 @@ static int __devinit platform_pci_init(struct pci_dev *pdev,
ret = gnttab_init();
if (ret)
goto out;
- xenbus_probe(NULL);
ret = xen_setup_shutdown_event();
if (ret)
goto out;
+ xenbus_probe(NULL);
return 0;
out:
--
1.7.0.4
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next reply other threads:[~2011-03-03 16:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 16:46 Frank Pan [this message]
2011-03-03 18:29 ` [PATCH pvops] Fix a bug that shutdown watcher is disabled on pvops Konrad Rzeszutek Wilk
2011-03-04 2:09 ` Frank Pan
2011-03-04 8:41 ` Ian Campbell
2011-03-04 9:29 ` Frank Pan
2011-03-04 11:51 ` Ian Campbell
2011-03-04 2:39 ` Frank Pan
2011-03-04 2:57 ` Frank Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikUyYpVKG_LZHFLL-ziCfU-Oc3qM9uFCd7QH13Z@mail.gmail.com \
--to=frankpzh@gmail.com \
--cc=Ian.Campbell@citrix.com \
--cc=Jeremy.Fitzhardinge@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).