xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: eXeC001er <execooler@gmail.com>
To: Xen-devel <xen-devel@lists.xensource.com>
Subject: [PATCH] blktap/blktap2: Fix for incorrect parse disk configuration (xen-unstable)
Date: Sun, 11 Jul 2010 12:16:03 +0400	[thread overview]
Message-ID: <AANLkTim2LM7oFG1y2xBRSRR1ZwexS1Ds06Rl3fTNdQXa@mail.gmail.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 365 bytes --]

Current source-code work if use following configuration:
config example:    disk=['tap:vhd:/path/../disk.img,xvda,w']

but not work if use:
config example:    disk=['tap:tapdisk:vhd:/path/../disk.img,xvda,w']
Error during start DomU:    File 'vhd:/path/.../disk.img' doesn't exist.

this patch fix this bug.

Signed-off-by: eXeC001er <execooler@gmail.com>

Thanks.

[-- Attachment #1.2: Type: text/html, Size: 1768 bytes --]

[-- Attachment #2: blktap_incorrect_parse.patch --]
[-- Type: text/x-patch, Size: 567 bytes --]

diff -r a672af698bc3 tools/python/xen/util/blkif.py
--- a/tools/python/xen/util/blkif.py	Fri Jul 09 12:35:58 2010 +0100
+++ b/tools/python/xen/util/blkif.py	Sun Jul 11 12:13:34 2010 +0400
@@ -87,7 +87,10 @@
                 fn = "/dev/%s" %(fn,)
                
         if typ in ("tap", "tap2"):
-            (taptype, fn) = fn.split(":", 1)
+            if fn.count(":") == 1:
+                (taptype, fn) = fn.split(":", 1)
+            else:
+                (taptype, fn) = fn.split(":", 2)[1:3]
     return (fn, taptype)
 
 def blkdev_uname_to_file(uname):

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

             reply	other threads:[~2010-07-11  8:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-11  8:16 eXeC001er [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-07-11  8:57 [PATCH] blktap/blktap2: Fix for incorrect parse disk configuration (xen-unstable) Boris Derzhavets
2010-07-11  9:16 ` eXeC001er
2010-07-11 13:06   ` Boris Derzhavets

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTim2LM7oFG1y2xBRSRR1ZwexS1Ds06Rl3fTNdQXa@mail.gmail.com \
    --to=execooler@gmail.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).