From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: Re: [Qemu-devel] [PATCH V11 00/15] Xen device model
	support
Date: Tue, 22 Mar 2011 14:47:09 +0000
Message-ID: <AANLkTim49k4j5epjeRHnGooB3mQPrMte9D-kXNftC4i1@mail.gmail.com>
References: <1299004529-31290-1-git-send-email-anthony.perard@citrix.com>
	<4D88B0C6.6040506@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4D88B0C6.6040506@suse.de>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Alexander Graf <agraf@suse.de>
Cc: Xen Devel <xen-devel@lists.xensource.com>, QEMU-devel <qemu-devel@nongnu.org>, Anthony Liguori <anthony@codemonkey.ws>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, Mar 22, 2011 at 14:23, Alexander Graf <agraf@suse.de> wrote:
> On 03/01/2011 07:35 PM, anthony.perard@citrix.com wrote:
>>
>> From: Anthony PERARD<anthony.perard@citrix.com>
>>
>> Hi all,
>>
>> Here is the few change since the V10:
>>
>> =C2=A0 - Add braces for blocks with single statement in the clean-up pat=
ch;
>> =C2=A0 - the patch that builds Xen only for x86 have been removed, inste=
ad,
>> =C2=A0 =C2=A0 xen_domainbuild is built with libhw and other Xen files ar=
e built for
>> i386
>> =C2=A0 =C2=A0 target only;
>> =C2=A0 - the redirection structure with function pointer have been remov=
ed,
>> instead,
>> =C2=A0 =C2=A0 there are few #define or static inline function use for th=
e
>> compatibility;
>
> ARGH!
>
> The point of the redirection structure was so I can plug in with xenner a=
nd
> replace all the xen calls with in-qemu versions. If you remove it, I'll h=
ave
> to put it back in in the xenner patch set :(.
>
> We need some sort of abstraction between calling xs_ functions and actual=
ly
> calling them. Wrapping all xs_ calls in static inlines would be fine for
> that, as would the indirect calling table.

As my series doesn't change a lot of things in the xen code, I think
it is better than you put it back in your patch set.

Regards,

--=20
Anthony PERARD