Re: xenpaging crashes xen in is_iomem_page()

[Patrick Colp <pjcolp@cs.ubc.ca>]

On 26 July 2010 10:58, Tim Deegan <Tim.Deegan@citrix.com> wrote:
> Hi,
>
> At 15:39 +0100 on 26 Jul (1280158794), Patrick Colp wrote:
>> On 26 July 2010 10:08, Olaf Hering <olaf@aepfle.de> wrote:
>> > Is there a portable way to check for the EPT flag in xenpaging?
>>
>> Yeah, this can be added. Probably not a bad idea, really. I actually
>> have some code to test if a machine has EPT enabled or not (by
>> borrowing some of the Xen start-up code which checks for things like
>> EPT)
>
> Good idea.  From inside Xen you should be checking hap_enabled(d) (since
> even on an EPT machine the tools can request shadow pagetables for
> individual domains).  Outside Xen I'm not sure there's a reliable way of
> detecting HAP; maybe the xenpaging hypercalls should return an error?

Right, checks against hap_enabled make sense too. From outside Xen, I
can detect if EPT is enabled for the machine. This doesn't guarantee
it's enabled for a given guest nor if it returns "EPT disabled" does
it mean the machine doesn't have EPT (it just means that EPT isn't
enabled at the time). However, it might be better to just put the
checks in Xen and return an error through the domctls if HAP isn't
enabled, as you suggest.


Patrick