From mboxrd@z Thu Jan 1 00:00:00 1970 From: eXeC001er Subject: Re: [PATCH] Re: blktap2 problem with pvops kernel 2.6.32.13 and xen 4.0-rc1 Date: Sun, 30 May 2010 19:00:24 +0400 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=0016e649ca46fb675c0487d0ff0f Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: Boris Derzhavets , Xen-devel List-Id: xen-devel@lists.xenproject.org --0016e649ca46fb675c0487d0ff0f Content-Type: multipart/alternative; boundary=0016e649ca46fb67490487d0ff0d --0016e649ca46fb67490487d0ff0d Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable this patch remove problems with blktap2 devices: 1. If we use blktap2 disk device then DomU does not boot. Returned error: F= ile 'vhd:/path/.../disk.img' doesn't exist. 2. Created blktap2 disk device does not accessible immediately after connecting: If we use pygrub then DomU does not boot. Returned error: Disk is not accessible. Signed-off-by: eXeC001er --- 2010/5/30 Keir Fraser > Needs a patch description and a signed-off-by line. > > -- Keir > > On 30/05/2010 13:21, "eXeC001er" wrote: > > > My python-experience is small, but i tied to rewrite. > > New in attach. > > > > 2010/5/30 Keir Fraser > >> On 30/05/2010 11:37, "Pasi K=C3=A4rkk=C3=A4inen" wrote: > >> > >>> On Sun, May 30, 2010 at 02:02:06PM +0400, eXeC001er wrote: > >>>> I have already sent a patch 1 weak ago. > (blktap2_control_func.patch) > >>>> repeat in attach. > >>>> Thanks. > >>> > >>> Ok, thanks. > >>> > >>> Keir: I guess this is not committed yet? > >> > >> I'm not too happy about the sleep(5). I guess if there's no better > solution > >> coming up I should just whack this patch in? > >> > >> -- Keir > >> > >>> -- Pasi > >>> > >>>> 2010/5/30 Pasi K=C3=A4rkk=C3=A4inen <[1]pasik@iki.fi> > >>>> > >>>> On Sun, May 30, 2010 at 11:17:51AM +0400, eXeC001er wrote: > >>>>> I've attempted to install Nexenta Core 3 image under Xen 4.0 > >>>> (2.6.32.13 > >>>>> pvops) on top of F13. Sample nexenta3.cfg profile contains 4 > >>>> lines like > >>>>> this:- > >>>>> > >>>>> disk=3D['tat:tapdisk:vhd:/path/../disk.img,xvda,w'] ( from sam= ple) > >>>>> > >>>>> It generates message > >>>>> =C3=82 File 'vhd:/path/.../disk.img' doesn't exist. > >>>>> > >>>>> Boris. > >>>>> P.S. It was already in one of the threads @xen-users. > >>>>> > >>>>> This bug in "def _parse_uname(uname):" > >>>> (tools/python/xen/util/blkif.py) > >>>>> (taptype, fn) =3D fn.split(":", 1) >>>>>>=C3=82 (taptype, fn) = =3D > >>>> fn.split(":", > >>>>> 2)[1:3] > >>>> > >>>> Can you send a proper patch, as unified diff (diff -u), with a > >>>> Signed-off-by line? > >>>> -- Pasi > >>>> > >>>> References > >>>> > >>>> Visible links > >>>> 1. mailto:pasik@iki.fi > >>> > >>>> diff -r d0420ab97345 tools/python/xen/util/blkif.py > >>>> --- a/tools/python/xen/util/blkif.py Fri May 21 16:21:39 2010 +0100 > >>>> +++ b/tools/python/xen/util/blkif.py Sat May 22 01:21:15 2010 +0400 > >>>> @@ -87,7 +87,7 @@ > >>>> fn =3D "/dev/%s" %(fn,) > >>>> > >>>> if typ in ("tap", "tap2"): > >>>> - (taptype, fn) =3D fn.split(":", 1) > >>>> + (taptype, fn) =3D fn.split(":", 2)[1:] > >>>> return (fn, taptype) > >>>> > >>>> def blkdev_uname_to_file(uname): > >>>> diff -r d0420ab97345 tools/python/xen/xend/XendDomainInfo.py > >>>> --- a/tools/python/xen/xend/XendDomainInfo.py Fri May 21 16:21:39 20= 10 > >>>> +0100 > >>>> +++ b/tools/python/xen/xend/XendDomainInfo.py Sat May 22 01:21:15 20= 10 > >>>> +0400 > >>>> @@ -3292,6 +3292,7 @@ > >>>> fn =3D BOOTLOADER_LOOPBACK_DEVICE > >>>> > >>>> try: > >>>> + time.sleep(5) > >>>> blcfg =3D bootloader(blexec, fn, self, False, > >>>> bootloader_args, kernel, ramdisk= , > args) > >>>> finally: > >>>> @@ -3299,7 +3300,7 @@ > >>>> log.info ("Unmounting %s from > %s." % > >>>> (fn, BOOTLOADER_LOOPBACK_DEVICE)) > >>>> > >>>> - dom0.destroyDevice('tap', > BOOTLOADER_LOOPBACK_DEVICE) > >>>> + dom0.destroyDevice(devtype, > >>>> BOOTLOADER_LOOPBACK_DEVICE) > >>>> > >>>> if blcfg is None: > >>>> msg =3D "Had a bootloader specified, but can't find > disk" > >>> > >> > >> > > > > > > > --0016e649ca46fb67490487d0ff0d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
this patch remove problems with blktap2 devices:
1. If we use blktap2 disk= device then DomU does not boot. Returned error:=C2=A0File 'vhd:= /path/.../disk.img' doesn't exist.
2. Created blktap2 disk d= evice does not accessible=C2=A0immediately after connecting: If we use p= ygrub then DomU does not boot. Returned error: Disk is not accessible.

Signed-off-by: eXeC001er <execooler@gmail.com>
---

2010/5/30 Keir Fraser <keir.fraser@eu.citrix.com>
Needs a patch description and a signed-off-by line.

=C2=A0-- Keir

On 30/05/2010 13:21, "eXeC001er" <execooler@gmail.com> wrote:

> My python-experience=C2=A0is small, but i tied to rewrite.
> New in attach.
>
> 2010/5/30 Keir Fraser <keir.fraser@eu.citrix.com>
>> On 30/05/2010 11:37, "Pasi K=C3=A4rkk=C3=A4inen" <pasik@iki.fi> wrote:
>>
>>> On Sun, May 30, 2010 at 02:02:06PM +0400, eXeC001er wrote:
>>>> =C2=A0 =C2=A0I have already sent a patch 1 weak ago. (blkt= ap2_control_func.patch)
>>>> =C2=A0 =C2=A0repeat in attach.
>>>> =C2=A0 =C2=A0Thanks.
>>>
>>> Ok, thanks.
>>>
>>> Keir: I guess this is not committed yet?
>>
>> I'm not too happy about the sleep(5). I guess if there's n= o better solution
>> coming up I should just whack this patch in?
>>
>> =C2=A0-- Keir
>>
>>> -- Pasi
>>>
>>>> =C2=A0 =C2=A02010/5/30 Pasi K=C3=A4rkk=C3=A4inen <[1]pasik@iki.fi>
>>>>
>>>> =C2=A0 =C2=A0 =C2=A0On Sun, May 30, 2010 at 11:17:51AM +04= 00, eXeC001er wrote:
>>>>> =C2=A0 =C2=A0 =C2=A0I've attempted to install Nexe= nta Core 3 image under Xen 4.0
>>>> =C2=A0 =C2=A0 =C2=A0(2.6.32.13
>>>>> =C2=A0 =C2=A0 =C2=A0pvops) on top of F13. Sample nexen= ta3.cfg profile contains 4
>>>> =C2=A0 =C2=A0 =C2=A0lines like
>>>>> =C2=A0 =C2=A0 =C2=A0this:-
>>>>>
>>>>> =C2=A0 =C2=A0 =C2=A0disk=3D['tat:tapdisk:vhd:/path= /../disk.img,xvda,w'] ( from sample)
>>>>>
>>>>> =C2=A0 =C2=A0 =C2=A0It generates message
>>>>> =C2=A0 =C2=A0 =C2=A0=C3=82 File 'vhd:/path/.../dis= k.img' doesn't exist.
>>>>>
>>>>> =C2=A0 =C2=A0 =C2=A0Boris.
>>>>> =C2=A0 =C2=A0 =C2=A0P.S. It was already in one of the = threads @xen-users.
>>>>>
>>>>> =C2=A0 =C2=A0This bug in "def _parse_uname(uname)= :"
>>>> =C2=A0 =C2=A0 =C2=A0(tools/python/xen/util/blkif.py)
>>>>> =C2=A0 =C2=A0(taptype, fn) =3D fn.split(":",= 1) >>>>>>=C3=82 (taptype, fn) =3D
>>>> =C2=A0 =C2=A0 =C2=A0fn.split(":",
>>>>> =C2=A0 =C2=A02)[1:3]
>>>>
>>>> =C2=A0 =C2=A0 =C2=A0Can you send a proper patch, as unifie= d diff (diff -u), with a
>>>> =C2=A0 =C2=A0 =C2=A0Signed-off-by line?
>>>> =C2=A0 =C2=A0 =C2=A0-- Pasi
>>>>
>>>> References
>>>>
>>>> =C2=A0 =C2=A0Visible links
>>>> =C2=A0 =C2=A01. mailto:pas= ik@iki.fi
>>>
>>>> diff -r d0420ab97345 tools/python/xen/util/blkif.py
>>>> --- a/tools/python/xen/util/blkif.py Fri May 21 16:21:39 2= 010 +0100
>>>> +++ b/tools/python/xen/util/blkif.py Sat May 22 01:21:15 2= 010 +0400
>>>> @@ -87,7 +87,7 @@
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0fn =3D "/dev/%s" %(fn,)
>>>>
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if typ in ("tap&quo= t;, "tap2"):
>>>> - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(taptype, fn) = =3D fn.split(":", 1)
>>>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(taptype, fn) = =3D fn.split(":", 2)[1:]
>>>> =C2=A0 =C2=A0 =C2=A0return (fn, taptype)
>>>>
>>>> =C2=A0def blkdev_uname_to_file(uname):
>>>> diff -r d0420ab97345 tools/python/xen/xend/XendDomainInfo.= py
>>>> --- a/tools/python/xen/xend/XendDomainInfo.py Fri May 21 1= 6:21:39 2010
>>>> +0100
>>>> +++ b/tools/python/xen/xend/XendDomainInfo.py Sat May 22 0= 1:21:15 2010
>>>> +0400
>>>> @@ -3292,6 +3292,7 @@
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0fn =3D BOOTLOADER_LOOPBACK_DEVICE
>>>>
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0try:
>>>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0t= ime.sleep(5)
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0blcfg =3D bootloader(blexec, fn, self, False,
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 bootl= oader_args, kernel, ramdisk, args)
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0finally: >>>> @@ -3299,7 +3300,7 @@
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0log.info <http://log= .info> ("Unmounting %s from %s." %
>>>> =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 (fn, BOOTLOADER_LOOPBACK_DEVICE))
>>>>
>>>> - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0dom0.destroyDevice('tap', BOOTLOADER_LOOPBACK_DEVICE)<= br> >>>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0dom0.destroyDevice(devtype,
>>>> BOOTLOADER_LOOPBACK_DEVICE)
>>>>
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if blcfg i= s None:
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0msg =3D "Had a bootloader specified, but can't find disk&quo= t;
>>>
>>
>>
>
>



--0016e649ca46fb67490487d0ff0d-- --0016e649ca46fb675c0487d0ff0f Content-Type: text/x-patch; charset=US-ASCII; name="bltap2_control_func.patch" Content-Disposition: attachment; filename="bltap2_control_func.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g9tzo5mn0 ZGlmZiAtciA5MzQxMGU1ZTRhZDggdG9vbHMvcHl0aG9uL3hlbi91dGlsL2Jsa2lmLnB5Ci0tLSBh L3Rvb2xzL3B5dGhvbi94ZW4vdXRpbC9ibGtpZi5weQlTYXQgTWF5IDIyIDA2OjM2OjQxIDIwMTAg KzAxMDAKKysrIGIvdG9vbHMvcHl0aG9uL3hlbi91dGlsL2Jsa2lmLnB5CVN1biBNYXkgMzAgMTY6 MTc6NTQgMjAxMCArMDQwMApAQCAtODcsNyArODcsNyBAQAogICAgICAgICAgICAgICAgIGZuID0g Ii9kZXYvJXMiICUoZm4sKQogICAgICAgICAgICAgICAgCiAgICAgICAgIGlmIHR5cCBpbiAoInRh cCIsICJ0YXAyIik6Ci0gICAgICAgICAgICAodGFwdHlwZSwgZm4pID0gZm4uc3BsaXQoIjoiLCAx KQorICAgICAgICAgICAgKHRhcHR5cGUsIGZuKSA9IGZuLnNwbGl0KCI6IiwgMilbMTozXQogICAg IHJldHVybiAoZm4sIHRhcHR5cGUpCiAKIGRlZiBibGtkZXZfdW5hbWVfdG9fZmlsZSh1bmFtZSk6 CmRpZmYgLXIgOTM0MTBlNWU0YWQ4IHRvb2xzL3B5dGhvbi94ZW4veGVuZC9YZW5kQm9vdGxvYWRl ci5weQotLS0gYS90b29scy9weXRob24veGVuL3hlbmQvWGVuZEJvb3Rsb2FkZXIucHkJU2F0IE1h eSAyMiAwNjozNjo0MSAyMDEwICswMTAwCisrKyBiL3Rvb2xzL3B5dGhvbi94ZW4veGVuZC9YZW5k Qm9vdGxvYWRlci5weQlTdW4gTWF5IDMwIDE2OjE3OjU0IDIwMTAgKzA0MDAKQEAgLTEzLDYgKzEz LDcgQEAKICMKIAogaW1wb3J0IG9zLCBzZWxlY3QsIGVycm5vLCBzdGF0LCBzaWduYWwsIHR0eQor aW1wb3J0IHRpbWUKIGltcG9ydCByYW5kb20KIGltcG9ydCBzaGxleAogZnJvbSB4ZW4ueGVuZCBp bXBvcnQgc3hwCkBAIC0zOCwxMCArMzksMTYgQEAKICAgICAgICAgbXNnID0gIkJvb3Rsb2FkZXIg aXNuJ3QgZXhlY3V0YWJsZSIKICAgICAgICAgbG9nLmVycm9yKG1zZykKICAgICAgICAgcmFpc2Ug Vm1FcnJvcihtc2cpCi0gICAgaWYgbm90IG9zLmFjY2VzcyhkaXNrLCBvcy5SX09LKToKLSAgICAg ICAgbXNnID0gIkRpc2sgaXNuJ3QgYWNjZXNzaWJsZSIKLSAgICAgICAgbG9nLmVycm9yKG1zZykK LSAgICAgICAgcmFpc2UgVm1FcnJvcihtc2cpCisgICAgYXR0ZW1wdCA9IDAKKyAgICB3aGlsZSBU cnVlOgorICAgICAgICBpZiBub3Qgb3MuYWNjZXNzKGRpc2ssIG9zLlJfT0spIGFuZCBhdHRlbXB0 ID4gMzoKKyAgICAgICAgICAgIG1zZyA9ICJEaXNrIGlzbid0IGFjY2Vzc2libGUiCisgICAgICAg ICAgICBsb2cuZXJyb3IobXNnKQorICAgICAgICAgICAgcmFpc2UgVm1FcnJvcihtc2cpCisgICAg ICAgIGVsc2U6CisgICAgICAgICAgICBicmVhaworICAgICAgICB0aW1lLnNsZWVwKDEpCisgICAg ICAgIGF0dGVtcHQgPSBhdHRlbXB0ICsgMQogCiAgICAgaWYgb3MudW5hbWUoKVswXSA9PSAiTmV0 QlNEIiBhbmQgZGlzay5zdGFydHN3aXRoKCcvZGV2LycpOgogICAgICAgIGRpc2sgPSBkaXNrLnJl cGxhY2UoIi9kZXYvIiwgIi9kZXYvciIpCmRpZmYgLXIgOTM0MTBlNWU0YWQ4IHRvb2xzL3B5dGhv bi94ZW4veGVuZC9YZW5kRG9tYWluSW5mby5weQotLS0gYS90b29scy9weXRob24veGVuL3hlbmQv WGVuZERvbWFpbkluZm8ucHkJU2F0IE1heSAyMiAwNjozNjo0MSAyMDEwICswMTAwCisrKyBiL3Rv b2xzL3B5dGhvbi94ZW4veGVuZC9YZW5kRG9tYWluSW5mby5weQlTdW4gTWF5IDMwIDE2OjE3OjU0 IDIwMTAgKzA0MDAKQEAgLTMyOTksNyArMzI5OSw3IEBACiAgICAgICAgICAgICAgICAgICAgIGxv Zy5pbmZvKCJVbm1vdW50aW5nICVzIGZyb20gJXMuIiAlCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIChmbiwgQk9PVExPQURFUl9MT09QQkFDS19ERVZJQ0UpKQogCi0gICAgICAgICAgICAg ICAgICAgIGRvbTAuZGVzdHJveURldmljZSgndGFwJywgQk9PVExPQURFUl9MT09QQkFDS19ERVZJ Q0UpCisgICAgICAgICAgICAgICAgICAgIGRvbTAuZGVzdHJveURldmljZShkZXZ0eXBlLCBCT09U TE9BREVSX0xPT1BCQUNLX0RFVklDRQogCiAgICAgICAgICAgICBpZiBibGNmZyBpcyBOb25lOgog ICAgICAgICAgICAgICAgIG1zZyA9ICJIYWQgYSBib290bG9hZGVyIHNwZWNpZmllZCwgYnV0IGNh bid0IGZpbmQgZGlzayIK --0016e649ca46fb675c0487d0ff0f Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --0016e649ca46fb675c0487d0ff0f--