From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dulloor <dulloor@gmail.com>
Subject: Re: [XEN][vNUMA][PATCH 7/9] Build NUMA HVM
Date: Mon, 5 Jul 2010 23:07:35 -0700
Message-ID: <AANLkTimclNp67GSt7sb_EWM_6kE3ABWS4X20iJo02F8J@mail.gmail.com>
References: <1BEA8649F0C00540AB2811D7922ECB6C9338B4D2@orsmsx507.amr.corp.intel.com>
	<AANLkTil6lggj7AAMWZ31WG1b-J1MxUMI3M4FvKQMPAZ8@mail.gmail.com>
	<AANLkTincPzp_MHzKwHvnOjSe5Ci-fUftWlo7uClTk6VK@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <AANLkTincPzp_MHzKwHvnOjSe5Ci-fUftWlo7uClTk6VK@mail.gmail.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

WIth the NUMA allocator, pod is simply disabled as of now. This debug
statement seeped through when testing that. Will take care of it :)
However, I did test PoD for any regressions.

-dulloor

On Mon, Jul 5, 2010 at 2:55 AM, George Dunlap
<George.Dunlap@eu.citrix.com> wrote:
> What's this line for:
>
>>+ =A0 =A0if (nr_pages > target_pages)
>> =A0 =A0 {
>>- =A0 =A0 =A0 =A0PERROR("Could not allocate memory.");
>>- =A0 =A0 =A0 =A0goto error_out;
>>+ =A0 =A0 =A0 =A0pod_mode =3D 1;
>>+ =A0 =A0 =A0 =A0mem_flags |=3D XENMEMF_populate_on_demand;
>>+ =A0 =A0 =A0 =A0IPRINTF("I SHOULDN'T BE HERE !!\n");
>
> It's not clear what this patch does to the PoD logic... does it still
> need some work, or should I try harder to grok it? =A0Have you tested it
> in PoD mode?
>
> =A0-George
>