From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Markey Subject: Re: XCP: pygrub missing ext4 support. Date: Mon, 21 Jun 2010 12:38:17 +0100 Message-ID: References: <20100619160714.GN17817@reaktio.net> <4C1F37E7.5030500@redhat.com> <4C1F4CFE.7040806@redhat.com> Reply-To: admin@dmarkey.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0828606537==" Return-path: In-Reply-To: <4C1F4CFE.7040806@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Michal Novotny Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org --===============0828606537== Content-Type: multipart/alternative; boundary=001485f6d830b1c9af048988bdd0 --001485f6d830b1c9af048988bdd0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable The *non-e2fsprogs* implementation, i.e. tools/libfsimage/ext2fs/fsys_ext2fs.c has ext4 support already. On 21 June 2010 12:29, Michal Novotny wrote: > On 06/21/2010 01:26 PM, David Markey wrote: > >> Well, which ever way we do it, either using the built in libfsimage ext4 >> support, or upgrading e2fsprogs, we should choose one? >> >> >> > Well, when using libfsimage *non-e2fsprogs* implementation the ext4 suppo= rt > have to be added manually but when using e2fsprogs implementation (i.e. t= he > version linked with e2fsprogs) I recommend upgrading your version of > e2fsprogs to the newest/upstream version. > > Michal > > On 21 June 2010 10:59, Michal Novotny > minovotn@redhat.com>> wrote: >> >> On 06/19/2010 06:07 PM, Pasi K=E4rkk=E4inen wrote: >> >> On Sat, Jun 19, 2010 at 05:00:57PM +0100, David Markey wrote: >> >> XCP pygrub should have ext4 support. >> It currently doesn't because the libfsimage ext2fs-lib >> module is linked >> against libext2fs, which doesnt have ext4 support in XCP. >> Instead, XCP should use the ext2fs module that comes >> with libfsimage, >> which has ext4 support. >> Most new releases of distributions has it as their >> default filesystem. >> Most notably, Ubuntu 10.04 >> >> >> Also Fedora 12, Fedora 13, upcoming Debian 6.0 ("Squeeze") and >> RHEL6. >> >> -- Pasi >> >> >> Well, this is not the Xen issue here. We're having this fixed in >> RHEL-5 by simply reinstalling the e2fsprogs package to the latest >> one, although in case of RHEL-5 it's been renamed to e4fsprogs. >> The simplest thing you can do about this is to reinstall the >> e2fsprogs package on the host machine and it will be working fine >> - at least it was when I did test it on RHEL-5 some time ago. >> >> Simply put, reinstalling the e2fsprogs to the latest version will >> do the job and allow ext4 functionality to pygrub. >> >> Michal >> >> >> >> An easy way for the build to use ext2fs instead of >> ext2fs-lib, is to not >> have ext2fs/ext2fs.h present. >> Alternatively this patch hard codes it. >> (From 4.0) >> --- a/tools/libfsimage/Makefile 2010-06-19 >> 16:52:04.231221516 >> +0100 >> +++ b/tools/libfsimage/Makefile 2010-06-19 >> 16:52:08.803250922 >> +0100 >> @@ -1,8 +1,7 @@ >> XEN_ROOT =3D ../.. >> include $(XEN_ROOT)/tools/Rules.mk >> >> -SUBDIRS-y =3D common ufs reiserfs iso9660 fat zfs >> -SUBDIRS-y +=3D $(shell env CC=3D"$(CC)" ./check-libext2fs= ) >> +SUBDIRS-y =3D common ufs reiserfs iso9660 fat zfs ext2fs >> >> .PHONY: all clean install >> all clean install: %: subdirs-% >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> >> >> http://lists.xensource.com/xen-devel >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> >> >> http://lists.xensource.com/xen-devel >> >> >> >> -- Michal Novotny>, >> RHCE >> >> Virtualization Team (xen userspace), Red Hat >> >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> >> http://lists.xensource.com/xen-devel >> >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel >> >> > > > -- > Michal Novotny, RHCE > Virtualization Team (xen userspace), Red Hat > > --001485f6d830b1c9af048988bdd0 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable The=A0*non-e2fsprogs* implementation, i.e.=A0tools/libfsimage/ext2fs/fsys_e= xt2fs.c has ext4 support already.


On= 21 June 2010 12:29, Michal Novotny <minovotn@redhat.com> wrote:
On 06/21/2010 01:26 PM, D= avid Markey wrote:
Well, which ever way we do it, either using the built in libfsimage ext4 su= pport, or upgrading e2fsprogs, we should choose one?



Well, when using libfsimage *non-e2fsprogs* implementation the ext4 support= have to be added manually but when using e2fsprogs implementation (i.e. th= e version linked with e2fsprogs) I recommend upgrading your version of e2fs= progs to the newest/upstream version.

Michal

On 21 June 2010 10:59, Michal Novotny <minovotn@redhat.com <mailto:minovotn@redhat.com>> wr= ote:

=A0 =A0On 06/19/2010 06:07 PM, Pasi K=E4rkk=E4inen wrote:

=A0 =A0 =A0 =A0On Sat, Jun 19, 2010 at 05:00:57PM +0100, David Markey wrot= e:

=A0 =A0 =A0 =A0 =A0 =A0 =A0 XCP pygrub should have ext4 support.
=A0 =A0 =A0 =A0 =A0 =A0 =A0 It currently doesn't because the libfsimag= e ext2fs-lib
=A0 =A0 =A0 =A0 =A0 =A0module is linked
=A0 =A0 =A0 =A0 =A0 =A0 =A0 against libext2fs, which doesnt have ext4 supp= ort in XCP.
=A0 =A0 =A0 =A0 =A0 =A0 =A0 Instead, XCP should use the ext2fs module that= comes
=A0 =A0 =A0 =A0 =A0 =A0with libfsimage,
=A0 =A0 =A0 =A0 =A0 =A0 =A0 which has ext4 support.
=A0 =A0 =A0 =A0 =A0 =A0 =A0 Most new releases of distributions has it as t= heir
=A0 =A0 =A0 =A0 =A0 =A0default filesystem.
=A0 =A0 =A0 =A0 =A0 =A0 =A0 Most notably, Ubuntu 10.04


=A0 =A0 =A0 =A0Also Fedora 12, Fedora 13, upcoming Debian 6.0 ("Squee= ze") and
=A0 =A0 =A0 =A0RHEL6.

=A0 =A0 =A0 =A0-- Pasi


=A0 =A0Well, this is not the Xen issue here. We're having this fixed i= n
=A0 =A0RHEL-5 by simply reinstalling the e2fsprogs package to the latest =A0 =A0one, although in case of RHEL-5 it's been renamed to e4fsprogs.=
=A0 =A0The simplest thing you can do about this is to reinstall the
=A0 =A0e2fsprogs package on the host machine and it will be working fine =A0 =A0- at least it was when I did test it on RHEL-5 some time ago.

=A0 =A0Simply put, reinstalling the e2fsprogs to the latest version will =A0 =A0do the job and allow ext4 functionality to pygrub.

=A0 =A0Michal



=A0 =A0 =A0 =A0 =A0 =A0 =A0 An easy way for the build to use ext2fs instea= d of
=A0 =A0 =A0 =A0 =A0 =A0ext2fs-lib, is to not
=A0 =A0 =A0 =A0 =A0 =A0 =A0 have ext2fs/ext2fs.h present.
=A0 =A0 =A0 =A0 =A0 =A0 =A0 Alternatively this patch hard codes it.
=A0 =A0 =A0 =A0 =A0 =A0 =A0 (From 4.0)
=A0 =A0 =A0 =A0 =A0 =A0 =A0 --- a/tools/libfsimage/Makefile =A0 =A0 =A0 = =A0 2010-06-19
=A0 =A0 =A0 =A0 =A0 =A016:52:04.231221516
=A0 =A0 =A0 =A0 =A0 =A0 =A0 +0100
=A0 =A0 =A0 =A0 =A0 =A0 =A0 +++ b/tools/libfsimage/Makefile =A0 =A0 =A0 = =A0 2010-06-19
=A0 =A0 =A0 =A0 =A0 =A016:52:08.803250922
=A0 =A0 =A0 =A0 =A0 =A0 =A0 +0100
=A0 =A0 =A0 =A0 =A0 =A0 =A0 @@ -1,8 +1,7 @@
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0XEN_ROOT =3D ../..
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0include $(XEN_ROOT)/tools/Rules.mk

=A0 =A0 =A0 =A0 =A0 =A0 =A0 -SUBDIRS-y =3D common ufs reiserfs iso9660 fat= zfs
=A0 =A0 =A0 =A0 =A0 =A0 =A0 -SUBDIRS-y +=3D $(shell env CC=3D"$(CC)&q= uot; ./check-libext2fs)
=A0 =A0 =A0 =A0 =A0 =A0 =A0 +SUBDIRS-y =3D common ufs reiserfs iso9660 fat= zfs ext2fs

=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0.PHONY: all clean install
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0all clean install: %: subdirs-%


=A0 =A0 =A0 =A0 =A0 =A0_______________________________________________
=A0 =A0 =A0 =A0 =A0 =A0Xen-devel mailing list
=A0 =A0 =A0 =A0 =A0 =A0Xen-devel@lists.xensource.com
=A0 =A0 =A0 =A0 =A0 =A0<mailto:Xen-devel@lists.xensource.com>

=A0 =A0 =A0 =A0 =A0 =A0http://lists.xensource.com/xen-devel


=A0 =A0 =A0 =A0_______________________________________________
=A0 =A0 =A0 =A0Xen-devel mailing list
=A0 =A0 =A0 =A0Xen-devel@lists.xensource.com
=A0 =A0 =A0 =A0<mailto:Xen-devel@lists.xensource.com>
<= br> =A0 =A0 =A0 =A0http://lists.xensource.com/xen-devel



=A0 =A0-- =A0 =A0 Michal Novotny<minovotn@redhat.com <mailto:minovotn@redhat.com>>, RHCE
=A0 =A0Virtualization Team (xen userspace), Red Hat



=A0 =A0_______________________________________________
=A0 =A0Xen-devel mailing list
=A0 =A0= Xen-devel@lists.xensource.com <mailto:Xen-devel@lists.xensource.com><= div class=3D"im">
=A0 =A0= http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-deve= l@lists.xensource.com
http://l= ists.xensource.com/xen-devel
=A0


--
Michal Novotny<= minovotn@redhat.com>, RHCE
Virtualization Team (xen userspace), Red Hat


--001485f6d830b1c9af048988bdd0-- --===============0828606537== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============0828606537==--