Re: Re: changeset 22526:7a5ee3800417

[George Dunlap <George.Dunlap@eu.citrix.com>]

[-- Attachment #1: Type: text/plain, Size: 1980 bytes --]

Peng fei,

Can you test the attached patch (to xen-unstable)?  I don't have
EPT-enabled hardware handy...

 -George

On Mon, Mar 7, 2011 at 4:20 PM, George Dunlap <george.dunlap@citrix.com> wrote:
> Hmm, yeah, that's obviously not right!  Let me take a look...
>
>  -George
>
> On Mon, 2011-03-07 at 09:55 +0000, 张鹏飞 wrote:
>> Hi,
>>     Recently, I did a research on the p2m and EPT,and did apply your
>> patch(22526) to the source code of mine. But there is one place
>> confused me:
>>
>>
>>
>> ept_entry = table + index;
>> 1.91
>>     1.92 -        ept_entry->emt = epte_get_entry_emt(d, gfn, mfn, &ipat, direct_mmio);
>>     1.93 -        ept_entry->ipat = ipat;
>>     1.94 -        ept_entry->sp = i ? 1 : 0;
>>     1.95 -        ept_entry->avail1 = p2mt;
>>     1.96 -        ept_entry->avail2 = 0;
>>     1.97 +        new_entry.emt = epte_get_entry_emt(d, gfn, mfn, &ipat, direct_mmio);
>>     1.98 +        new_entry.ipat = ipat;
>>     1.99 +        new_entry.sp = i ? 1 : 0;
>>    1.100 +        new_entry.avail1 = p2mt;
>>    1.101 +        new_entry.avail2 = 0;
>>    1.102
>>    1.103 -        if ( ept_entry->mfn == mfn_x(mfn) )
>>    1.104 +        if ( new_entry.mfn == mfn_x(mfn) )
>>    1.105               need_modify_vtd_table = 0;
>>    1.106          else /* the caller should take care of the previous page */
>>    1.107 -            ept_entry->mfn = mfn_x(mfn);
>>    1.108 +            new_entry.mfn = mfn_x(mfn);
>>
>> I think, The new_entry.mfn is used without assigned any value. Maybe there was something else I did not think of.
>> Thank you for your kindness!
>>
>> http://xenbits.xen.org/xen-unstable.hg/rev/7a5ee3800417
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>

[-- Attachment #2: ept-use-existing-entry.diff --]
[-- Type: text/x-diff, Size: 891 bytes --]

diff -r 809ea782d2e6 -r 7ddd021a2079 xen/arch/x86/mm/hap/p2m-ept.c
--- a/xen/arch/x86/mm/hap/p2m-ept.c	Mon Mar 07 16:33:45 2011 +0000
+++ b/xen/arch/x86/mm/hap/p2m-ept.c	Mon Mar 07 16:41:02 2011 +0000
@@ -390,7 +390,7 @@
             new_entry.access = p2ma;
             new_entry.rsvd2_snp = (iommu_enabled && iommu_snoop);
 
-            if ( new_entry.mfn == mfn_x(mfn) )
+            if ( ept_entry->mfn == mfn_x(mfn) )
                 need_modify_vtd_table = 0;
             else
                 new_entry.mfn = mfn_x(mfn);
@@ -438,7 +438,7 @@
         new_entry.access = p2ma;
         new_entry.rsvd2_snp = (iommu_enabled && iommu_snoop);
 
-        if ( new_entry.mfn == mfn_x(mfn) )
+        if ( ept_entry->mfn == mfn_x(mfn) )
              need_modify_vtd_table = 0;
         else /* the caller should take care of the previous page */
             new_entry.mfn = mfn_x(mfn);

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel