From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: Re: changeset 22526:7a5ee3800417 Date: Mon, 7 Mar 2011 16:41:02 +0000 Message-ID: References: <1299514840.19262.4698.camel@elijah> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=e0cb4e43cce143c923049de72985 Return-path: In-Reply-To: <1299514840.19262.4698.camel@elijah> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: George Dunlap Cc: xen devel , =?UTF-8?B?5byg6bmP6aOe?= List-Id: xen-devel@lists.xenproject.org --e0cb4e43cce143c923049de72985 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Peng fei, Can you test the attached patch (to xen-unstable)? I don't have EPT-enabled hardware handy... -George On Mon, Mar 7, 2011 at 4:20 PM, George Dunlap wr= ote: > Hmm, yeah, that's obviously not right! =C2=A0Let me take a look... > > =C2=A0-George > > On Mon, 2011-03-07 at 09:55 +0000, =E5=BC=A0=E9=B9=8F=E9=A3=9E wrote: >> Hi, >> =C2=A0 =C2=A0 Recently, I did a research on the p2m and EPT,and did appl= y your >> patch(22526) to the source code of mine. But there is one place >> confused me: >> >> >> >> ept_entry =3D table + index; >> 1.91 >> =C2=A0 =C2=A0 1.92 - =C2=A0 =C2=A0 =C2=A0 =C2=A0ept_entry->emt =3D epte_= get_entry_emt(d, gfn, mfn, &ipat, direct_mmio); >> =C2=A0 =C2=A0 1.93 - =C2=A0 =C2=A0 =C2=A0 =C2=A0ept_entry->ipat =3D ipat= ; >> =C2=A0 =C2=A0 1.94 - =C2=A0 =C2=A0 =C2=A0 =C2=A0ept_entry->sp =3D i ? 1 = : 0; >> =C2=A0 =C2=A0 1.95 - =C2=A0 =C2=A0 =C2=A0 =C2=A0ept_entry->avail1 =3D p2= mt; >> =C2=A0 =C2=A0 1.96 - =C2=A0 =C2=A0 =C2=A0 =C2=A0ept_entry->avail2 =3D 0; >> =C2=A0 =C2=A0 1.97 + =C2=A0 =C2=A0 =C2=A0 =C2=A0new_entry.emt =3D epte_g= et_entry_emt(d, gfn, mfn, &ipat, direct_mmio); >> =C2=A0 =C2=A0 1.98 + =C2=A0 =C2=A0 =C2=A0 =C2=A0new_entry.ipat =3D ipat; >> =C2=A0 =C2=A0 1.99 + =C2=A0 =C2=A0 =C2=A0 =C2=A0new_entry.sp =3D i ? 1 := 0; >> =C2=A0 =C2=A01.100 + =C2=A0 =C2=A0 =C2=A0 =C2=A0new_entry.avail1 =3D p2m= t; >> =C2=A0 =C2=A01.101 + =C2=A0 =C2=A0 =C2=A0 =C2=A0new_entry.avail2 =3D 0; >> =C2=A0 =C2=A01.102 >> =C2=A0 =C2=A01.103 - =C2=A0 =C2=A0 =C2=A0 =C2=A0if ( ept_entry->mfn =3D= =3D mfn_x(mfn) ) >> =C2=A0 =C2=A01.104 + =C2=A0 =C2=A0 =C2=A0 =C2=A0if ( new_entry.mfn =3D= =3D mfn_x(mfn) ) >> =C2=A0 =C2=A01.105 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 need= _modify_vtd_table =3D 0; >> =C2=A0 =C2=A01.106 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0else /* the caller = should take care of the previous page */ >> =C2=A0 =C2=A01.107 - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ept_entry-= >mfn =3D mfn_x(mfn); >> =C2=A0 =C2=A01.108 + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0new_entry.= mfn =3D mfn_x(mfn); >> >> I think, The new_entry.mfn is used without assigned any value. Maybe the= re was something else I did not think of. >> Thank you for your kindness! >> >> http://xenbits.xen.org/xen-unstable.hg/rev/7a5ee3800417 > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel > --e0cb4e43cce143c923049de72985 Content-Type: text/x-diff; charset=US-ASCII; name="ept-use-existing-entry.diff" Content-Disposition: attachment; filename="ept-use-existing-entry.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gkzmd81j0 ZGlmZiAtciA4MDllYTc4MmQyZTYgLXIgN2RkZDAyMWEyMDc5IHhlbi9hcmNoL3g4Ni9tbS9oYXAv cDJtLWVwdC5jCi0tLSBhL3hlbi9hcmNoL3g4Ni9tbS9oYXAvcDJtLWVwdC5jCU1vbiBNYXIgMDcg MTY6MzM6NDUgMjAxMSArMDAwMAorKysgYi94ZW4vYXJjaC94ODYvbW0vaGFwL3AybS1lcHQuYwlN b24gTWFyIDA3IDE2OjQxOjAyIDIwMTEgKzAwMDAKQEAgLTM5MCw3ICszOTAsNyBAQAogICAgICAg ICAgICAgbmV3X2VudHJ5LmFjY2VzcyA9IHAybWE7CiAgICAgICAgICAgICBuZXdfZW50cnkucnN2 ZDJfc25wID0gKGlvbW11X2VuYWJsZWQgJiYgaW9tbXVfc25vb3ApOwogCi0gICAgICAgICAgICBp ZiAoIG5ld19lbnRyeS5tZm4gPT0gbWZuX3gobWZuKSApCisgICAgICAgICAgICBpZiAoIGVwdF9l bnRyeS0+bWZuID09IG1mbl94KG1mbikgKQogICAgICAgICAgICAgICAgIG5lZWRfbW9kaWZ5X3Z0 ZF90YWJsZSA9IDA7CiAgICAgICAgICAgICBlbHNlCiAgICAgICAgICAgICAgICAgbmV3X2VudHJ5 Lm1mbiA9IG1mbl94KG1mbik7CkBAIC00MzgsNyArNDM4LDcgQEAKICAgICAgICAgbmV3X2VudHJ5 LmFjY2VzcyA9IHAybWE7CiAgICAgICAgIG5ld19lbnRyeS5yc3ZkMl9zbnAgPSAoaW9tbXVfZW5h YmxlZCAmJiBpb21tdV9zbm9vcCk7CiAKLSAgICAgICAgaWYgKCBuZXdfZW50cnkubWZuID09IG1m bl94KG1mbikgKQorICAgICAgICBpZiAoIGVwdF9lbnRyeS0+bWZuID09IG1mbl94KG1mbikgKQog ICAgICAgICAgICAgIG5lZWRfbW9kaWZ5X3Z0ZF90YWJsZSA9IDA7CiAgICAgICAgIGVsc2UgLyog dGhlIGNhbGxlciBzaG91bGQgdGFrZSBjYXJlIG9mIHRoZSBwcmV2aW91cyBwYWdlICovCiAgICAg ICAgICAgICBuZXdfZW50cnkubWZuID0gbWZuX3gobWZuKTsK --e0cb4e43cce143c923049de72985 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --e0cb4e43cce143c923049de72985--