From: Patrick Colp <pjcolp@cs.ubc.ca>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH 1 of 3] xenpaging: Add a check to Xen for EPT
Date: Wed, 28 Jul 2010 10:35:38 -0400 [thread overview]
Message-ID: <AANLkTinAkK+CMR-GgUuyAfxAZ7TCRK=dbq_LEEx-1Mg7@mail.gmail.com> (raw)
In-Reply-To: <19536.14245.81116.651418@mariner.uk.xensource.com>
ENOSYS tends to be used to indicate an invalid/unsupported domctl. I
chose ENODEV as an alternative so that it provides a unique error
return code and seemed relatively sane (vs say something like E2BIG).
I'm not particularly fussed about what the actually error code is, I
just wanted it to be able to distinguish a lack-of-EPT-support error
from other errors (the other error codes in use in the mem-event
enable domctl are ENOSYS and EINVAL). If you have a suggestion for
another one to use, I'm happy to hear it.
Patrick
On 28 July 2010 09:59, Ian Jackson <Ian.Jackson@eu.citrix.com> wrote:
> I wrote:
>> I haven't tested this but this and the corresponding patch 2/3 to
>> produce a better error message look sane. [...]
>
> I meant 3/3. I have some comments on 2/3.
>
> Ian.
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>
>
next prev parent reply other threads:[~2010-07-28 14:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 21:21 [PATCH 0 of 3] xenpaging: Check that EPT is enabled for target guest Patrick Colp
2010-07-27 21:21 ` [PATCH 1 of 3] xenpaging: Add a check to Xen for EPT Patrick Colp
2010-07-28 13:58 ` Ian Jackson
2010-07-28 13:59 ` Ian Jackson
2010-07-28 14:35 ` Patrick Colp [this message]
2010-07-28 15:19 ` Ian Jackson
2010-07-27 21:21 ` [PATCH 2 of 3] xenpaging: Fix-up xenpaging tool code Patrick Colp
2010-07-28 14:00 ` Ian Jackson
2010-07-28 14:57 ` Patrick Colp
2010-07-28 15:01 ` Gianni Tedesco
2010-07-28 15:28 ` Patrick Colp
2010-07-28 16:27 ` Patrick Colp
2010-07-28 15:06 ` Keir Fraser
2010-07-27 21:21 ` [PATCH 3 of 3] xenpaging: Add check to xenpaging tool for EPT error from Xen Patrick Colp
2010-09-15 8:37 ` Jiang, Yunhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTinAkK+CMR-GgUuyAfxAZ7TCRK=dbq_LEEx-1Mg7@mail.gmail.com' \
--to=pjcolp@cs.ubc.ca \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).