From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick Colp Subject: Re: [PATCH 1 of 3] xenpaging: Add a check to Xen for EPT Date: Wed, 28 Jul 2010 10:35:38 -0400 Message-ID: References: <6cb61775657f6ea362b3.1280265685@talisker.cs.ubc.ca> <19536.14212.497792.462787@mariner.uk.xensource.com> <19536.14245.81116.651418@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <19536.14245.81116.651418@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org ENOSYS tends to be used to indicate an invalid/unsupported domctl. I chose ENODEV as an alternative so that it provides a unique error return code and seemed relatively sane (vs say something like E2BIG). I'm not particularly fussed about what the actually error code is, I just wanted it to be able to distinguish a lack-of-EPT-support error from other errors (the other error codes in use in the mem-event enable domctl are ENOSYS and EINVAL). If you have a suggestion for another one to use, I'm happy to hear it. Patrick On 28 July 2010 09:59, Ian Jackson wrote: > I wrote: >> I haven't tested this but this and the corresponding patch 2/3 to >> produce a better error message look sane. =C2=A0[...] > > I meant 3/3. =C2=A0I have some comments on 2/3. > > Ian. > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel > >