From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shriram Rajagopalan Subject: Re: [PATCH 09 of 30] tools: blktap2: copy xenstore/hashtable.h into blktap2 Date: Mon, 21 Mar 2011 13:47:18 -0700 Message-ID: References: <30a1f7d0aa1097fd2b3f.1300718672@localhost.localdomain> <19847.37607.622295.871747@mariner.uk.xensource.com> Reply-To: rshriram@cs.ubc.ca Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1377754127==" Return-path: In-Reply-To: <19847.37607.622295.871747@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: xen-devel@lists.xensource.com, Ian Campbell List-Id: xen-devel@lists.xenproject.org --===============1377754127== Content-Type: multipart/alternative; boundary=20cf307f30ba24f428049f043e98 --20cf307f30ba24f428049f043e98 Content-Type: text/plain; charset=ISO-8859-1 On Mon, Mar 21, 2011 at 11:03 AM, Ian Jackson wrote: > Ian Campbell writes ("[Xen-devel] [PATCH 09 of 30] tools: blktap2: copy > xenstore/hashtable.h into blktap2"): > > tools: blktap2: copy xenstore/hashtable.h into blktap2 > > > > hashtable.c has already been copied, forked and modified, there > > doesn't seem much point in avoiding the same for the header until > > someone feels motivated to properly refactor. > > Before we make this any worse, perhaps we should at least leave a > comment in every copy of hashtable.c referring to every other clone ? > > Ian. > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel > copying hashtable.h alone wont suffice. hashtable_itr.h in blktap2/drivers includes hashtable_private.h in xenstore/ And a diff -wu blktap2/drivers/hashtable.c xenstore/hashtable.c shows no functional difference between the two versions. How about pulling the hashtable.h, hashtable.c, hashtable_private.h from xenstore/ and hashtable_itr.[h,c], hashtable_utility.[h,c] from blktap2/drivers/ into one common separate area, like utils/ or something. Also, I suggest moving all code from hashtable_itr.c and hashtable_utility.c into hashtable.c (and adding the appropriate declarations to hashtable.h). The copyrights and attributions in the files seem to be the same. We could get rid of all the clutter and have just 3 files related to hashtable, common to both xenstore and blktap2/drivers/. shriram --20cf307f30ba24f428049f043e98 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On Mon, Mar 21, 2011 at 11:03 AM, Ian Jackson <Ian.Jackso= n@eu.citrix.com> wrote:
Ian Campbell writes ("[Xen-devel] [PATCH 09 of 30] tools: blktap2: cop= y xenstore/hashtable.h into blktap2"):
> tools: blktap2: copy xenstore/hashtable.h into blkta= p2
>
> hashtable.c has already been copied, forked and modified, there
> doesn't seem much point in avoiding the same for the header until<= br> > someone feels motivated to properly refactor.

Before we make this any worse, perhaps we should at least leave a
comment in every copy of hashtable.c referring to every other clone ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.= com
http://l= ists.xensource.com/xen-devel
copying h= ashtable.h alone wont suffice.
hashtable_itr.h in blktap2/drivers includ= es hashtable_private.h in xenstore/

And a diff -wu blktap2/drivers/hashtable.c xenstore/hashtable.c shows n= o functional
difference between the two versions.
=A0 How about pull= ing the hashtable.h, hashtable.c, hashtable_private.h from xenstore/
and hashtable_itr.[h,c], hashtable_utility.[h,c] from blktap2/drivers/ into= one common
separate area, like utils/ or something.

Also, I suggest moving all = code from hashtable_itr.c and hashtable_utility.c
into hashtable.c (and= adding the appropriate declarations to hashtable.h). The copyrights
and attributions in the files seem to be the same. We could get rid of all = the clutter and
have just 3 files related to hashtable, common to both = xenstore and blktap2/drivers/.

shriram
--20cf307f30ba24f428049f043e98-- --===============1377754127== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============1377754127==--