From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Markey Subject: XCP: pygrub missing ext4 support. Date: Sat, 19 Jun 2010 17:00:57 +0100 Message-ID: Reply-To: admin@dmarkey.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1248094111==" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Xen-devel List-Id: xen-devel@lists.xenproject.org --===============1248094111== Content-Type: multipart/alternative; boundary=001485f07b54608cca0489642de7 --001485f07b54608cca0489642de7 Content-Type: text/plain; charset=ISO-8859-1 XCP pygrub should have ext4 support. It currently doesn't because the libfsimage ext2fs-lib module is linked against libext2fs, which doesnt have ext4 support in XCP. Instead, XCP should use the ext2fs module that comes with libfsimage, which has ext4 support. Most new releases of distributions has it as their default filesystem. Most notably, Ubuntu 10.04 An easy way for the build to use ext2fs instead of ext2fs-lib, is to not have ext2fs/ext2fs.h present. Alternatively this patch hard codes it. (From 4.0) --- a/tools/libfsimage/Makefile 2010-06-19 16:52:04.231221516 +0100 +++ b/tools/libfsimage/Makefile 2010-06-19 16:52:08.803250922 +0100 @@ -1,8 +1,7 @@ XEN_ROOT = ../.. include $(XEN_ROOT)/tools/Rules.mk -SUBDIRS-y = common ufs reiserfs iso9660 fat zfs -SUBDIRS-y += $(shell env CC="$(CC)" ./check-libext2fs) +SUBDIRS-y = common ufs reiserfs iso9660 fat zfs ext2fs .PHONY: all clean install all clean install: %: subdirs-% --001485f07b54608cca0489642de7 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable XCP pygrub should have ext4 support.

It currently doesn&= #39;t because the libfsimage ext2fs-lib module is linked against=A0libext2f= s, which doesnt have ext4 support in XCP.

Instead,= XCP should use the ext2fs module that comes with libfsimage, which has ext= 4 support.

Most new releases of distributions has it as their defa= ult filesystem. Most=A0notably, Ubuntu 10.04

An ea= sy way for the build to use ext2fs instead of ext2fs-lib, is to not have=A0= ext2fs/ext2fs.h present.

Alternatively this patch hard codes it.

<= /div>

(From 4.0)
--- a/tools/libfsimage/Makefi= le 2010-06-= 19 16:52:04.231221516 +0100
+++ b/tools/libfsimage/Makefile 2010-06-19 16:52:08.803250922 +0100
@@ -1,8 +1,7 @@
=A0XEN_ROOT =3D ../..
=A0include $(XE= N_ROOT)/tools/Rules.mk
=A0
-SUBDIRS-y =3D common ufs reiserfs iso9660 fat zfs
=
-SUBDIRS-y +=3D $(shell env CC=3D"$(CC)" ./check-libext2fs)<= /div>
+SUBDIRS-y =3D common ufs reiserfs iso9660 fat zfs ext2fs
=A0
=A0.PHONY: all clean install
=A0all clean install: %: subdir= s-%

--001485f07b54608cca0489642de7-- --===============1248094111== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============1248094111==--