Re: [PATCH 2/2 v2] xen: Fix 16550 UART console for HP Moonshot (Aarch64) platform

[George Dunlap <George.Dunlap@citrix.com>]

On Nov 15, 2017, at 9:20 PM, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> 
> On Thu, Nov 09, 2017 at 03:49:24PM +0530, Bhupinder Thakur wrote:
>>    The console was not working on HP Moonshot (HPE Proliant Aarch64) because
>>    the UART registers were accessed as 8-bit aligned addresses. However,
>>    registers are 32-bit aligned for HP Moonshot.
>> 
>>    Since ACPI/SPCR table does not specify the register shift to be applied to the
>>    register offset, this patch implements an erratum to correctly set the register
>>    shift for HP Moonshot.
>> 
>>    Similar erratum was implemented in linux:
>> 
>>    commit 79a648328d2a604524a30523ca763fbeca0f70e3
>>    Author: Loc Ho <lho@apm.com>
>>    Date:   Mon Jul 3 14:33:09 2017 -0700
>> 
>>        ACPI: SPCR: Workaround for APM X-Gene 8250 UART 32-alignment errata
>> 
>>        APM X-Gene verion 1 and 2 have an 8250 UART with its register
>>        aligned to 32-bit. In addition, the latest released BIOS
>>        encodes the access field as 8-bit access instead 32-bit access.
>>        This causes no console with ACPI boot as the console
>>        will not match X-Gene UART port due to the lack of mmio32
>>        option.
>> 
>>        Signed-off-by: Loc Ho <lho@apm.com>
>>        Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>        Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Any particular reason you offset this whole commit description by four spaces?

I get this effect when I use “git show” to look at a changeset for some reason.  Bhupinder, did you perhaps export a changeset as a patch using “git show” and then re-import it?

In any case, this needs to be fixed.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel