xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "James Harper" <james.harper@bendigoit.com.au>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: xen-devel@lists.xensource.com
Subject: RE: first attempt of pvscai backend driver port to pvops
Date: Fri, 12 Mar 2010 11:37:05 +1100	[thread overview]
Message-ID: <AEC6C66638C05B468B556EA548C1A77D01918DA3@trantor> (raw)
In-Reply-To: <4B99864E.3080907@goop.org>

> 
> It does need some cleaning up.  Run it through
> linux/scripts/checkpatch.pl and iterate until its fairly clean (as
clean
> as possible without making it barbarous).  Most obvious is that kernel
> code uses 8-width hard tabs.
> 
> The patch also seems to contain usbback.  Did you mean to include it?

I sure didn't. Not sure how that got there...
 
> If possible and sensible, split the patch into logically separate
parts
> (like introduce infrastructure, use infrastructure for a, for b, for
> c).  However for these kinds of "new subsystem" patches, it often
makes
> most sense to just have one large patch adding the new code.
> 
> Please base the patches on (ideally) 2.6.31 or .32.  If you need some
> Xen infrastructure (which is likely), then base the patch on the
> xen/dom0/backend/common branch.

They are based on xen/master at the moment.

> Mail your patches to the list for review (but, please, inlined plain
> text).  But the easiest way for me to include the patches is if I can
> pull them from your git server.  If you can't make your own machine
> accessible, you can set up an account on github.com, or ask for an
> account on kernel.org.

I'll look at doing that.

> 
> I haven't actually looked at the substance of the patch yet.
> 

Probably best not to bother until I've cleaned up some of the above.

Thanks

James

  reply	other threads:[~2010-03-12  0:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-11 23:29 first attempt of pvscai backend driver port to pvops James Harper
2010-03-12  0:09 ` Jeremy Fitzhardinge
2010-03-12  0:37   ` James Harper [this message]
2010-04-14 17:20     ` first attempt of pvscsi " Pasi Kärkkäinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AEC6C66638C05B468B556EA548C1A77D01918DA3@trantor \
    --to=james.harper@bendigoit.com.au \
    --cc=jeremy@goop.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).