From mboxrd@z Thu Jan 1 00:00:00 1970 From: "James Harper" Subject: RE: first attempt of pvscai backend driver port to pvops Date: Fri, 12 Mar 2010 11:37:05 +1100 Message-ID: References: <4B99864E.3080907@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Return-path: Content-class: urn:content-classes:message In-Reply-To: <4B99864E.3080907@goop.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Fitzhardinge Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org >=20 > It does need some cleaning up. Run it through > linux/scripts/checkpatch.pl and iterate until its fairly clean (as clean > as possible without making it barbarous). Most obvious is that kernel > code uses 8-width hard tabs. >=20 > The patch also seems to contain usbback. Did you mean to include it? I sure didn't. Not sure how that got there... =20 > If possible and sensible, split the patch into logically separate parts > (like introduce infrastructure, use infrastructure for a, for b, for > c). However for these kinds of "new subsystem" patches, it often makes > most sense to just have one large patch adding the new code. >=20 > Please base the patches on (ideally) 2.6.31 or .32. If you need some > Xen infrastructure (which is likely), then base the patch on the > xen/dom0/backend/common branch. They are based on xen/master at the moment. > Mail your patches to the list for review (but, please, inlined plain > text). But the easiest way for me to include the patches is if I can > pull them from your git server. If you can't make your own machine > accessible, you can set up an account on github.com, or ask for an > account on kernel.org. I'll look at doing that. >=20 > I haven't actually looked at the substance of the patch yet. >=20 Probably best not to bother until I've cleaned up some of the above. Thanks James