xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "James Harper" <james.harper@bendigoit.com.au>
To: George Dunlap <George.Dunlap@eu.citrix.com>,
	Paul Durrant <Paul.Durrant@citrix.com>
Cc: xen devel <xen-devel@lists.xensource.com>
Subject: RE: PoD in other (not GPLPV) drivers
Date: Tue, 1 Mar 2011 09:09:02 +1100	[thread overview]
Message-ID: <AEC6C66638C05B468B556EA548C1A77D01C55A33@trantor> (raw)
In-Reply-To: <AANLkTinHU+iQEKdyOq+WMEiqZj+04iNvQOYFTvT=2LvX@mail.gmail.com>

> 
> Just for the public record: I believe that I have upstreamed all of
> the PoD fixes and improvements that we had in the XenServer tree with
> one exception: There are a series of patches to improve the "emergency
> zero-page sweep" behavior in Xen, particularly for pretty large
> (>24GiB) guests.  This is because:
> * They were really ugly; hacks upon hacks, not suitable for
upstreaming
> * As far as I know, they're performance enhancements only, not
correctness
> ones.
> 
> It doesn't sound to me like the zero-page sweeps should be involved in
> your issue, James.  But if you (or anyone) would like the patches, I'd
> be happy to send them along for you to try.  (And for the shy, or
> archaeologists looking at this long after I'm gone from Citrix, they
> can be found on the XenServer source ISOs.)  I'm not sure they'll
> apply cleanly to 4.1, but that code hasn't had a lot of changes, so
> you should be able to work out how they apply.
> 
> As part of my work to port XenServer to 4.1, I'm going to rewrite the
> patches, and I'll upstream them at that time.
> 

Even without pre-zeroing the memory under Windows, it is still pretty
slow doing the initial balloon down. Even though I ask windows not to
zero fill the page (therefore populating it), windows may still be
touching it though. But even then I give it straight back to xen so in
hindsight I think the zero page sweep shouldn't get invoked.

For testing I'm trying some pretty extreme numbers though, eg
maxmem=16384, memory=512, so ballooning down 15.5GB of memory is never
going to be that fast. I now suspect that the delay is in the Windows
API. When I balloon down during normal runtime it is about 10x slower
than ballooning up.

James

  reply	other threads:[~2011-02-28 22:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <AcvWIEDjcPpdP6eLTlqDXQDFzQWlHw==>
2011-02-27  1:47 ` PoD in other (not GPLPV) drivers James Harper
2011-02-28 11:59   ` George Dunlap
2011-02-28 12:17     ` Paul Durrant
2011-02-28 12:28       ` James Harper
2011-02-28 13:41         ` Paul Durrant
2011-02-28 14:17           ` George Dunlap
2011-02-28 22:09             ` James Harper [this message]
2011-02-28 22:20     ` James Harper
2011-03-03  9:58       ` George Dunlap
2011-03-03 10:22         ` James Harper
2011-03-03 11:30           ` Paul Durrant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AEC6C66638C05B468B556EA548C1A77D01C55A33@trantor \
    --to=james.harper@bendigoit.com.au \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Paul.Durrant@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).