xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Takeshi HASEGAWA <hasegaw@gmail.com>
To: Wei Liu <liuw@liuw.name>, Xen Devel <Xen-devel@lists.xensource.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH] libxl: virtio-blk-pci support for FV domain
Date: Sun, 8 May 2011 20:26:16 +0900	[thread overview]
Message-ID: <BANLkTi=eeu-wzDWCb-VithomzGk=EHjcVw@mail.gmail.com> (raw)
In-Reply-To: <BANLkTinow-MbvrAmHf7uck=ybS95RCiFBQ@mail.gmail.com>

My patch threats virtio block devices with same manner with xvd, sd, and hd.
Though, I need to discuss with xen developpers whether the vbd number
assignment is reasonable or not.

I guess blktap and blkback will never handle virto block device, so assigning
(reserving) the whole range of 2 << 28 for virtio block vbd may be more better.

Actually virtio is not Xen's VBD, so vbd number is not mandatory to work.
However, I believe this approach makes virtio block manageable
in same way as xvd and others.

I am looking forward for xen developpers' opinions.


Thanks,
Takeshi

2011/05/08 14:25 "Wei Liu" <liuw@liuw.name>:
> On Sun, May 8, 2011 at 12:56 PM, Wei Liu <liuw@liuw.name> wrote:
>> Thanks, I just started working on VirtIO block support yesterday.
>>
>> I was trying to add support to parse_disk_config() so that we can
>> specify "-if" option in the config file.
>>
>> I'm wondering which approach is better -- configure through
>> device_virtdisk_matches() or parse_disk_config() .
>>
>> Any suggestions?
>
> It seems that Takeshi's approach is better.
>
> I should follow libxl's conventions.
>
> --
> Best regards
> Wei Liu
> Twitter: @iliuw
> Site: http://liuw.name

  reply	other threads:[~2011-05-08 11:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-08  3:48 [PATCH] libxl: virtio-blk-pci support for FV domain Takeshi HASEGAWA
2011-05-08  4:56 ` Wei Liu
2011-05-08  5:24   ` Wei Liu
2011-05-08 11:26     ` Takeshi HASEGAWA [this message]
2011-05-09  9:04       ` Ian Campbell
2011-05-09 14:44       ` Stefano Stabellini
2011-05-09  8:56 ` Ian Campbell
2011-05-09  9:01   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTi=eeu-wzDWCb-VithomzGk=EHjcVw@mail.gmail.com' \
    --to=hasegaw@gmail.com \
    --cc=Xen-devel@lists.xensource.com \
    --cc=anthony.perard@citrix.com \
    --cc=liuw@liuw.name \
    --cc=stefano.stabellini@eu.citrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).