From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takeshi HASEGAWA Subject: Re: [PATCH] libxl: virtio-blk-pci support for FV domain Date: Sun, 8 May 2011 20:26:16 +0900 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Wei Liu , Xen Devel Cc: Anthony PERARD , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org My patch threats virtio block devices with same manner with xvd, sd, and hd. Though, I need to discuss with xen developpers whether the vbd number assignment is reasonable or not. I guess blktap and blkback will never handle virto block device, so assigning (reserving) the whole range of 2 << 28 for virtio block vbd may be more better. Actually virtio is not Xen's VBD, so vbd number is not mandatory to work. However, I believe this approach makes virtio block manageable in same way as xvd and others. I am looking forward for xen developpers' opinions. Thanks, Takeshi 2011/05/08 14:25 "Wei Liu" : > On Sun, May 8, 2011 at 12:56 PM, Wei Liu wrote: >> Thanks, I just started working on VirtIO block support yesterday. >> >> I was trying to add support to parse_disk_config() so that we can >> specify "-if" option in the config file. >> >> I'm wondering which approach is better -- configure through >> device_virtdisk_matches() or parse_disk_config() . >> >> Any suggestions? > > It seems that Takeshi's approach is better. > > I should follow libxl's conventions. > > -- > Best regards > Wei Liu > Twitter: @iliuw > Site: http://liuw.name