Re: [PATCH] mem_event: Allow memory access listener to perform single step execution

[Aravindh Puthiyaparambil <aravindh@virtuata.com>]

On Sat, May 28, 2011 at 12:53 AM, Keir Fraser <keir@xen.org> wrote:
> I removed and unrelated and pointless change that broke the x86_32 build, as
> c/s 23435. If that change is okay for you, I could backport the combination
> of 23434+23435 to 4.1.1.

Keir,

Sorry about the build breakage. I will test the 32-bit side of things
also in the future.

I did not realize VCPU pausing was nestable. So even after the
vcpu_unpause() in hvm_debug_op(), the VCPU will still be paused
because of the vcpu_pause() in p2m_mem_access_check()? If that is the
case I am fine with the combination for 4.1.1.

Thanks,
Aravindh

>  -- Keir
>
> On 27/05/2011 17:36, "Aravindh Puthiyaparambil" <aravindh@virtuata.com>
> wrote:
>
>> Can this be included in xen-4.1-testing.hg too so that it could make the Xen
>> 4.1.1 cut?
>>
>> Thanks,
>> Aravindh
>>
>> On May 27, 2011 1:39 AM, "Tim Deegan" <Tim.Deegan@citrix.com> wrote:
>>> At 04:39 +0100 on 27 May (1306471145), Aravindh Puthiyaparambil wrote:
>>>> mem_event: Allow memory access listener to perform single step execution.
>>>> Add a new memory event that handles single step. This allows the memory
>>>> access listener to handle instructions that modify data within the execution
>>>> page.
>>>> This can be enabled in the listener by doing:
>>>> xc_set_hvm_param(xch, domain_id, HVM_PARAM_MEMORY_EVENT_SINGLE_STEP,
>>>> HVMPME_mode_sync)
>>>>
>>>> Now the listener can start single stepping by:
>>>> xc_domain_debug_control(xch, domain_id, XEN_DOMCTL_DEBUG_OP_SINGLE_STEP_ON,
>>>> vcpu_id)
>>>>
>>>> And stop single stepping by:
>>>> xc_domain_debug_control(xch, domain_id, XEN_DOMCTL_DEBUG_OP_SINGLE_STEP_OFF,
>>>> vcpu_id)
>>>>
>>>> Signed-off-by: Aravindh Puthiyaparambil <aravindh@virtuata.com>
>>>
>>> Acked-by: Tim Deegan <Tim.Deegan@citrix.com>
>>>
>>> --
>>> Tim Deegan <Tim.Deegan@citrix.com>
>>> Principal Software Engineer, Xen Platform Team
>>> Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xensource.com
>> http://lists.xensource.com/xen-devel
>
>
>