From: ZhouPeng <zpengxen@gmail.com>
To: Christoph Egger <Christoph.Egger@amd.com>, ian.campbell@citrix.com
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH]tools/libxl: fix a bug in libxl__build_device_model_args_new. info->vncpasswd can't be empty if info->vncpasswd != NULL
Date: Fri, 15 Apr 2011 17:36:57 +0800 [thread overview]
Message-ID: <BANLkTikKZOOfstWHCu_iD_JxsBmjx8HsxA@mail.gmail.com> (raw)
In-Reply-To: <4DA801C4.5060102@amd.com>
[-- Attachment #1.1: Type: text/plain, Size: 1956 bytes --]
2011/4/15 Christoph Egger <Christoph.Egger@amd.com>
> On 04/15/11 10:33, ZhouPeng wrote:
>
>> Signed-off-by: Zhou Peng<zhoupeng@nfs.iscas.ac.cn>
>>
>> tools/libxl: fix a bug in libxl__build_device_model_args_new.
>> info->vncpasswd can't be empty if info->vncpasswd != NULL
>>
>>
> NACK! This can info->vncpasswd[0] contains '\0' if you have
>
>
> vncpasswd=''
>
> in the guest config file.
>
" if (info->vncpasswd&& info->vncpasswd[0]) “ can
vncpasswd='' in guest cfg file, when using upstream-qemu-xen
and block vncpasswd='passwd'
Can it be reasonable?
Christoph
>
>
> diff -r 3f00c5faa12a tools/libxl/libxl_dm.c
>> --- a/tools/libxl/libxl_dm.c Wed Apr 13 16:10:26 2011 +0100
>> +++ b/tools/libxl/libxl_dm.c Fri Apr 15 09:45:43 2011 +0800
>> @@ -209,7 +209,7 @@ static char ** libxl__build_device_model
>> int display = 0;
>> const char *listen = "127.0.0.1";
>>
>> - if (info->vncpasswd&& info->vncpasswd[0]) {
>> + if (info->vncpasswd&& !info->vncpasswd[0]) {
>> assert(!"missing code for supplying vnc password to qemu");
>> }
>> flexarray_append(dm_args, "-vnc");
>>
>> --
>> Zhou Peng
>> Operating System Technology Group
>> Institute of Software, the Chinese Academy of Sciences (ISCAS)
>> <mailto:ailvpeng25@gmail.com>
>>
>>
>
> --
> ---to satisfy European Law for business letters:
> Advanced Micro Devices GmbH
> Einsteinring 24, 85689 Dornach b. Muenchen
> Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
> Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
> Registergericht Muenchen, HRB Nr. 43632
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>
--
Zhou Peng
Operating System Technology Group
Institute of Software, the Chinese Academy of Sciences (ISCAS)
<ailvpeng25@gmail.com>
[-- Attachment #1.2: Type: text/html, Size: 3258 bytes --]
[-- Attachment #2: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2011-04-15 9:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 8:33 [PATCH]tools/libxl: fix a bug in libxl__build_device_model_args_new. info->vncpasswd can't be empty if info->vncpasswd != NULL ZhouPeng
2011-04-15 8:28 ` Christoph Egger
2011-04-15 8:42 ` Ian Campbell
2011-04-15 9:36 ` ZhouPeng [this message]
2011-04-15 9:37 ` Christoph Egger
2011-04-15 9:53 ` ZhouPeng
2011-04-15 10:02 ` ZhouPeng
2011-04-18 15:06 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikKZOOfstWHCu_iD_JxsBmjx8HsxA@mail.gmail.com \
--to=zpengxen@gmail.com \
--cc=Christoph.Egger@amd.com \
--cc=ian.campbell@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).