From: ZhouPeng <zpengxen@gmail.com>
To: "Xen-Devel (E-mail)" <xen-devel@lists.xensource.com>
Subject: [PATCH] libxl: fix against if condition
Date: Wed, 13 Apr 2011 14:43:53 +0800 [thread overview]
Message-ID: <BANLkTikM2WidQ4+Xcp1Cen+VemBKCTbyUg@mail.gmail.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 682 bytes --]
Signed-off-by: Zhou Peng <zhoupeng@nfs.iscas.ac.cn>
--- a/tools/libxl/libxl_dm.c Wed Apr 13 14:08:41 2011 +0800
+++ b/tools/libxl/libxl_dm.c Wed Apr 13 14:20:37 2011 +0800
@@ -197,7 +197,7 @@ static char ** libxl_build_device_model_
int display = 0;
const char *listen = "127.0.0.1";
- if (info->vncpasswd && info->vncpasswd[0]) {
+ if (info->vncpasswd && !info->vncpasswd[0]) {
assert(!"missing code for supplying vnc password to qemu");
}
flexarray_append(dm_args, "-vnc");
--
Zhou Peng
Operating System Technology Group
Institute of Software, the Chinese Academy of Sciences (ISCAS)
<ailvpeng25@gmail.com>
[-- Attachment #1.2: Type: text/html, Size: 894 bytes --]
[-- Attachment #2: libxl-against-if-condition.patch --]
[-- Type: text/x-patch, Size: 549 bytes --]
Signed-off-by: Zhou Peng <zhoupeng@nfs.iscas.ac.cn>
--- a/tools/libxl/libxl_dm.c Wed Apr 13 14:08:41 2011 +0800
+++ b/tools/libxl/libxl_dm.c Wed Apr 13 14:20:37 2011 +0800
@@ -197,7 +197,7 @@ static char ** libxl_build_device_model_
int display = 0;
const char *listen = "127.0.0.1";
- if (info->vncpasswd && info->vncpasswd[0]) {
+ if (info->vncpasswd && !info->vncpasswd[0]) {
assert(!"missing code for supplying vnc password to qemu");
}
flexarray_append(dm_args, "-vnc");
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next reply other threads:[~2011-04-13 6:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 6:43 ZhouPeng [this message]
2011-04-15 14:51 ` [PATCH] libxl: fix against if condition Ian Jackson
2011-04-16 5:48 ` ZhouPeng
2011-04-18 16:16 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikM2WidQ4+Xcp1Cen+VemBKCTbyUg@mail.gmail.com \
--to=zpengxen@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).