From mboxrd@z Thu Jan 1 00:00:00 1970 From: ZhouPeng Subject: [PATCH] libxl: fix against if condition Date: Wed, 13 Apr 2011 14:43:53 +0800 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=000e0cd2e110d65acf04a0c721c1 Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Xen-Devel (E-mail)" List-Id: xen-devel@lists.xenproject.org --000e0cd2e110d65acf04a0c721c1 Content-Type: multipart/alternative; boundary=000e0cd2e110d65aba04a0c721bf --000e0cd2e110d65aba04a0c721bf Content-Type: text/plain; charset=ISO-8859-1 Signed-off-by: Zhou Peng --- a/tools/libxl/libxl_dm.c Wed Apr 13 14:08:41 2011 +0800 +++ b/tools/libxl/libxl_dm.c Wed Apr 13 14:20:37 2011 +0800 @@ -197,7 +197,7 @@ static char ** libxl_build_device_model_ int display = 0; const char *listen = "127.0.0.1"; - if (info->vncpasswd && info->vncpasswd[0]) { + if (info->vncpasswd && !info->vncpasswd[0]) { assert(!"missing code for supplying vnc password to qemu"); } flexarray_append(dm_args, "-vnc"); -- Zhou Peng Operating System Technology Group Institute of Software, the Chinese Academy of Sciences (ISCAS) --000e0cd2e110d65aba04a0c721bf Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Signed-off-by: Zhou Peng <zh= oupeng@nfs.iscas.ac.cn>

--- a/tools/libxl/libxl_dm.c=A0=A0=A0= Wed Apr 13 14:08:41 2011 +0800
+++ b/tools/libxl/libxl_dm.c=A0=A0=A0 We= d Apr 13 14:20:37 2011 +0800
@@ -197,7 +197,7 @@ static char ** libxl_build_device_model_
=A0=A0=A0= =A0=A0=A0=A0=A0 int display =3D 0;
=A0=A0=A0=A0=A0=A0=A0=A0 const char *= listen =3D "127.0.0.1";
=A0
-=A0=A0=A0=A0=A0=A0=A0 if (info= ->vncpasswd && info->vncpasswd[0]) {
+=A0=A0=A0=A0=A0=A0=A0 if (info->vncpasswd && !info->vncpassw= d[0]) {
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 assert(!"missing code = for supplying vnc password to qemu");
=A0=A0=A0=A0=A0=A0=A0=A0 }=A0=A0=A0=A0=A0=A0=A0=A0 flexarray_append(dm_args, "-vnc");

--
Zhou Peng
Operating System Technology Group
Institute of S= oftware, the Chinese Academy of Sciences (ISCAS)

--000e0cd2e110d65aba04a0c721bf-- --000e0cd2e110d65acf04a0c721c1 Content-Type: text/x-patch; charset=US-ASCII; name="libxl-against-if-condition.patch" Content-Disposition: attachment; filename="libxl-against-if-condition.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gmfw6h4h0 U2lnbmVkLW9mZi1ieTogWmhvdSBQZW5nIDx6aG91cGVuZ0BuZnMuaXNjYXMuYWMuY24+CgotLS0g YS90b29scy9saWJ4bC9saWJ4bF9kbS5jICAgIFdlZCBBcHIgMTMgMTQ6MDg6NDEgMjAxMSArMDgw MAorKysgYi90b29scy9saWJ4bC9saWJ4bF9kbS5jICAgIFdlZCBBcHIgMTMgMTQ6MjA6MzcgMjAx MSArMDgwMApAQCAtMTk3LDcgKzE5Nyw3IEBAIHN0YXRpYyBjaGFyICoqIGxpYnhsX2J1aWxkX2Rl dmljZV9tb2RlbF8KICAgICAgICAgaW50IGRpc3BsYXkgPSAwOwogICAgICAgICBjb25zdCBjaGFy ICpsaXN0ZW4gPSAiMTI3LjAuMC4xIjsKIAotICAgICAgICBpZiAoaW5mby0+dm5jcGFzc3dkICYm IGluZm8tPnZuY3Bhc3N3ZFswXSkgeworICAgICAgICBpZiAoaW5mby0+dm5jcGFzc3dkICYmICFp bmZvLT52bmNwYXNzd2RbMF0pIHsKICAgICAgICAgICAgIGFzc2VydCghIm1pc3NpbmcgY29kZSBm b3Igc3VwcGx5aW5nIHZuYyBwYXNzd29yZCB0byBxZW11Iik7CiAgICAgICAgIH0KICAgICAgICAg ZmxleGFycmF5X2FwcGVuZChkbV9hcmdzLCAiLXZuYyIpOwoK --000e0cd2e110d65acf04a0c721c1 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --000e0cd2e110d65acf04a0c721c1--