xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Shriram Rajagopalan <rshriram@cs.ubc.ca>
To: "Liu, Jinsong" <jinsong.liu@intel.com>
Cc: "Li, Xin" <xin.li@intel.com>, Keir Fraser <keir.xen@gmail.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH] Fix save.py bug
Date: Wed, 18 May 2011 09:00:11 -0400	[thread overview]
Message-ID: <BANLkTikbNN9ZX5Q1ZcWBHBsQ+wGx21FSFA@mail.gmail.com> (raw)
In-Reply-To: <BC00F5384FCFC9499AF06F92E8B78A9E208381D9DC@shsmsx502.ccr.corp.intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 1749 bytes --]

On Wed, May 18, 2011 at 4:30 AM, Liu, Jinsong <jinsong.liu@intel.com> wrote:

> Resend it, it has been acked by Ian and Shriram, but seems to be ignored
> and didn't in unstable tree :)
>
> Thanks,
> Jinsong
>
> ================
> Fix save.py bug
>
> Fix save.py bug, to avoid compiling error under python2.4
>
> Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com>
> Acked-by: Ian Campbell <Ian.Campbell@eu.citrix.com>
> Acked-by: Shriram Rajagopalan <rshriram@cs.ubc.ca>
>
> diff -r f9bb0bbea7c2 tools/python/xen/remus/save.py
> --- a/tools/python/xen/remus/save.py    Thu May 12 16:42:54 2011 +0100
> +++ b/tools/python/xen/remus/save.py    Fri May 13 22:45:21 2011 +0800
> @@ -161,11 +161,12 @@ class Saver(object):
>
>         self.checkpointer = xen.lowlevel.checkpoint.checkpointer()
>         try:
> -            self.checkpointer.open(self.vm.domid)
> -            self.checkpointer.start(self.fd, self.suspendcb,
> self.resumecb,
> -                                    self.checkpointcb, self.interval)
> -        except xen.lowlevel.checkpoint.error, e:
> -            raise CheckpointError(e)
> +            try:
> +                self.checkpointer.open(self.vm.domid)
> +                self.checkpointer.start(self.fd, self.suspendcb,
> self.resumecb,
> +                                        self.checkpointcb, self.interval)
> +            except xen.lowlevel.checkpoint.error, e:
> +                raise CheckpointError(e)
>         finally:
>             try: #errors in checkpoint close are not critical atm.
>                 self.checkpointer.close()

>From my experience it takes couple of days for the patches to appear in the
unstable tree,
after they have been sent to the mailing list.
No point resending it. :)
shriram

[-- Attachment #1.2: Type: text/html, Size: 2247 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

  reply	other threads:[~2011-05-18 13:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-18  8:30 [PATCH] Fix save.py bug Liu, Jinsong
2011-05-18 13:00 ` Shriram Rajagopalan [this message]
2011-05-19 12:05   ` Liu, Jinsong
2011-05-20 16:54   ` Ian Jackson
2011-05-21  3:30     ` Liu, Jinsong
2011-05-21 11:29       ` Shriram Rajagopalan
2011-05-23  8:22     ` Liu, Jinsong
2011-05-24 15:13       ` Ian Jackson
2011-05-25  2:32         ` Liu, Jinsong
  -- strict thread matches above, loose matches on Subject: below --
2011-05-13 14:26 Liu, Jinsong
2011-05-13 14:36 ` Ian Campbell
2011-05-13 17:33   ` Liu, Jinsong
2011-05-17  1:58     ` Shriram Rajagopalan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTikbNN9ZX5Q1ZcWBHBsQ+wGx21FSFA@mail.gmail.com \
    --to=rshriram@cs.ubc.ca \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=jinsong.liu@intel.com \
    --cc=keir.xen@gmail.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=xin.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).