On Wed, May 18, 2011 at 4:30 AM, Liu, Jinsong <jinsong.liu@intel.com> wrote:

Resend it, it has been acked by Ian and Shriram, but seems to be ignored and didn't in unstable tree :)

Thanks,
Jinsong

================
Fix save.py bug

Fix save.py bug, to avoid compiling error under python2.4

Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com>
Acked-by: Ian Campbell <Ian.Campbell@eu.citrix.com>
Acked-by: Shriram Rajagopalan <rshriram@cs.ubc.ca>

diff -r f9bb0bbea7c2 tools/python/xen/remus/save.py
--- a/tools/python/xen/remus/save.py    Thu May 12 16:42:54 2011 +0100
+++ b/tools/python/xen/remus/save.py    Fri May 13 22:45:21 2011 +0800
@@ -161,11 +161,12 @@ class Saver(object):

        self.checkpointer = xen.lowlevel.checkpoint.checkpointer()
        try:
-            self.checkpointer.open(self.vm.domid)
-            self.checkpointer.start(self.fd, self.suspendcb, self.resumecb,
-                                    self.checkpointcb, self.interval)
-        except xen.lowlevel.checkpoint.error, e:
-            raise CheckpointError(e)
+            try:
+                self.checkpointer.open(self.vm.domid)
+                self.checkpointer.start(self.fd, self.suspendcb, self.resumecb,
+                                        self.checkpointcb, self.interval)
+            except xen.lowlevel.checkpoint.error, e:
+                raise CheckpointError(e)
        finally:
            try: #errors in checkpoint close are not critical atm.
                self.checkpointer.close()