Re: Re: [PATCH] libxl: basic support for virtio disk

[Wei Liu <liuw@liuw.name>]

On Fri, Jun 3, 2011 at 12:03 AM, Ian Jackson <Ian.Jackson@eu.citrix.com> wrote:
> Stefano Stabellini writes ("Re: [Xen-devel] Re: [PATCH] libxl: basic support for virtio disk"):
>> The limitation on the number of partitions is meaningless for virtio and
>> the limitation on the number of disks in arbitrary, as it is arbitrary
>> the current limitation on the number of scsi disks.
>
> So the code in libxl should accept any disk number that it can
> correctly format into an option to qemu, and allow qemu to deal with
> any resulting problems.
>
>> Device names like xvda1, xvda2, etc, are currently supported only with
>> PV guests.
>
> Currently the partition number is ignored.  Nonzero partitions should
> instead then be rejected.
>
>> There is no way to specify a single partition with HVM guests.
>> Considering that this patch is only meant for HVM guest, I think it is
>> correct to leave out the partition number.
>
> It should be checked, not ignored.
>
> Ian.
>

OK. Looks like the disk parsing code in libxl is going through a re-factoring.

I will get back to this patch when your re-factoring is done.

Wei.