[PATCH] tests: xen-access: minor bug fixes

[PATCH] tests: xen-access: minor bug fixes

[Aravindh Puthiyaparambil]

[-- Attachment #1.1: Type: text/plain, Size: 243 bytes --]

Can this patch be applied to both xen-unstable and xen-4.1-testing so that
it makes it into xen-4.1.1?

Thanks,
Aravindh


Fix a couple of minor bugs in xen-access test program.

Signed-off-by: Aravindh Puthiyaparambil <aravindh@virtuata.com>

[-- Attachment #1.2: Type: text/html, Size: 415 bytes --]

[-- Attachment #2: xen-access-bugfixes.patch --]
[-- Type: text/x-patch, Size: 700 bytes --]

diff -r 6a2089f00dc7 tools/tests/xen-access/xen-access.c
--- a/tools/tests/xen-access/xen-access.c	Fri Mar 25 10:22:10 2011 +0000
+++ b/tools/tests/xen-access/xen-access.c	Thu May 05 12:35:38 2011 -0700
@@ -482,9 +482,6 @@
 
     if ( argc == 3 && argv[0][0] == '-' )
     {
-        argv++;
-        argc--;
-
         if ( !strcmp(argv[0], "-m") )
             required = 1;
         else
@@ -492,6 +489,8 @@
             usage(progname);
             return -1;
         }
+        argv++;
+        argc--;
     }
 
     if ( argc != 2 )
@@ -651,8 +650,6 @@
     if ( rc == 0 )
         rc = rc1;
 
-    xc_interface_close(xch);
-
     DPRINTF("xenaccess exit code %d\n", rc);
     return rc;
 }


[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] tests: xen-access: minor bug fixes

[Ian Campbell]

On Thu, 2011-05-05 at 20:39 +0100, Aravindh Puthiyaparambil wrote:
> Can this patch be applied to both xen-unstable and xen-4.1-testing so
> that it makes it into xen-4.1.1?
[...]
> Fix a couple of minor bugs in xen-access test program.

It's always useful to describe _what_ bugs in a changelog message.

> Signed-off-by: Aravindh Puthiyaparambil <aravindh@virtuata.com>

Re: [PATCH] tests: xen-access: minor bug fixes

[Aravindh Puthiyaparambil]

[-- Attachment #1.1: Type: text/plain, Size: 680 bytes --]

On Fri, May 6, 2011 at 12:58 AM, Ian Campbell <Ian.Campbell@citrix.com>wrote:

> On Thu, 2011-05-05 at 20:39 +0100, Aravindh Puthiyaparambil wrote:
> > Can this patch be applied to both xen-unstable and xen-4.1-testing so
> > that it makes it into xen-4.1.1?
> [...]
> > Fix a couple of minor bugs in xen-access test program.
>
> It's always useful to describe _what_ bugs in a changelog message.
>
> > Signed-off-by: Aravindh Puthiyaparambil <aravindh@virtuata.com>
>
>
>
>
Sorry about that. Here is the explanation.
Thanks,
Aravindh

Fix -m option handling.
Fix a segfault that was occurring during program exit.

Signed-off-by: Aravindh Puthiyaparambil <aravindh@virtuata.com>

[-- Attachment #1.2: Type: text/html, Size: 1246 bytes --]

[-- Attachment #2: xen-access-bugfixes.patch --]
[-- Type: application/octet-stream, Size: 700 bytes --]

diff -r 6a2089f00dc7 tools/tests/xen-access/xen-access.c
--- a/tools/tests/xen-access/xen-access.c	Fri Mar 25 10:22:10 2011 +0000
+++ b/tools/tests/xen-access/xen-access.c	Thu May 05 12:35:38 2011 -0700
@@ -482,9 +482,6 @@
 
     if ( argc == 3 && argv[0][0] == '-' )
     {
-        argv++;
-        argc--;
-
         if ( !strcmp(argv[0], "-m") )
             required = 1;
         else
@@ -492,6 +489,8 @@
             usage(progname);
             return -1;
         }
+        argv++;
+        argc--;
     }
 
     if ( argc != 2 )
@@ -651,8 +650,6 @@
     if ( rc == 0 )
         rc = rc1;
 
-    xc_interface_close(xch);
-
     DPRINTF("xenaccess exit code %d\n", rc);
     return rc;
 }


[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel