Re: [PATCH] Play with spice for xen-upstream-qemu on upstream Xen

[ZhouPeng <zpengxen@gmail.com>]

It's fine.
Thanks

2011/5/26 Ian Jackson <Ian.Jackson@eu.citrix.com>:
> I wrote:
>> Yes, I agree.  I will make this change myself as it's just one
>> character :-).  Thanks for digging.
>
> Ian.
>
> # HG changeset patch
> # User Ian Jackson <Ian.Jackson@eu.citrix.com>
> # Date 1306416939 -3600
> # Node ID 240bdcce0ad2e0caa0fa9ee6448952239a219ab0
> # Parent  d8d24e8a81f8413eb25b14984f69d0e39e63eb3a
> libxl: add missing ":" in log messages
>
> libxl__logv would fail to put a ":" between the function name and the
> rest of the message.
>
> Reported-by: Zhou Peng <zhoupeng@nfs.iscas.ac.cn>
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
> Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
>
> diff -r d8d24e8a81f8 -r 240bdcce0ad2 tools/libxl/libxl_internal.c
> --- a/tools/libxl/libxl_internal.c      Thu May 26 14:33:52 2011 +0100
> +++ b/tools/libxl/libxl_internal.c      Thu May 26 14:35:39 2011 +0100
> @@ -168,7 +168,7 @@ void libxl__logv(libxl_ctx *ctx, xentool
>  x:
>     xtl_log(ctx->lg, msglevel, errnoval, "libxl",
>             "%s%s%s%s" "%s",
> -            fileline, func&&file?":":"", func?func:"", func||file?" ":"",
> +            fileline, func&&file?":":"", func?func:"", func||file?": ":"",
>             base);
>     if (base != enomem) free(base);
>     errno = esave;
>



-- 
Zhou Peng
Operating System Technology Group
Institute of Software, the Chinese Academy of Sciences (ISCAS)