From mboxrd@z Thu Jan  1 00:00:00 1970
From: ZhouPeng <zpengxen@gmail.com>
Subject: Re: [PATCH] Play with spice for xen-upstream-qemu on
	upstream Xen
Date: Thu, 26 May 2011 22:07:09 +0800
Message-ID: <BANLkTim-RXdDL1iym7WdJjt9tViAORFuyA@mail.gmail.com>
References: <BANLkTi=9OBXN0fMaPEvrEityAqM-L6yPBQ@mail.gmail.com>
	<19884.26020.847575.426352@mariner.uk.xensource.com>
	<BANLkTik5EKzCwFdV1D5w9wt1Gu6XZ4N4MA@mail.gmail.com>
	<19926.34224.455450.51781@mariner.uk.xensource.com>
	<BANLkTi=Dg_QQsa1b4Pin3RxYmoF=nFyk6A@mail.gmail.com>
	<BANLkTi=QGPb8eBcgp4qZvEwNVJkKybcxSA@mail.gmail.com>
	<19931.54520.528337.70653@mariner.uk.xensource.com>
	<BANLkTim0bGgem1UR8HvmFLAw7BajYsok6A@mail.gmail.com>
	<19934.22236.921974.790867@mariner.uk.xensource.com>
	<19934.22336.520004.747016@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <19934.22336.520004.747016@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "Xen-Devel (E-mail)" <xen-devel@lists.xensource.com>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

It's fine.
Thanks

2011/5/26 Ian Jackson <Ian.Jackson@eu.citrix.com>:
> I wrote:
>> Yes, I agree. =A0I will make this change myself as it's just one
>> character :-). =A0Thanks for digging.
>
> Ian.
>
> # HG changeset patch
> # User Ian Jackson <Ian.Jackson@eu.citrix.com>
> # Date 1306416939 -3600
> # Node ID 240bdcce0ad2e0caa0fa9ee6448952239a219ab0
> # Parent =A0d8d24e8a81f8413eb25b14984f69d0e39e63eb3a
> libxl: add missing ":" in log messages
>
> libxl__logv would fail to put a ":" between the function name and the
> rest of the message.
>
> Reported-by: Zhou Peng <zhoupeng@nfs.iscas.ac.cn>
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
> Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
>
> diff -r d8d24e8a81f8 -r 240bdcce0ad2 tools/libxl/libxl_internal.c
> --- a/tools/libxl/libxl_internal.c =A0 =A0 =A0Thu May 26 14:33:52 2011 +0=
100
> +++ b/tools/libxl/libxl_internal.c =A0 =A0 =A0Thu May 26 14:35:39 2011 +0=
100
> @@ -168,7 +168,7 @@ void libxl__logv(libxl_ctx *ctx, xentool
> =A0x:
> =A0 =A0 xtl_log(ctx->lg, msglevel, errnoval, "libxl",
> =A0 =A0 =A0 =A0 =A0 =A0 "%s%s%s%s" "%s",
> - =A0 =A0 =A0 =A0 =A0 =A0fileline, func&&file?":":"", func?func:"", func|=
|file?" ":"",
> + =A0 =A0 =A0 =A0 =A0 =A0fileline, func&&file?":":"", func?func:"", func|=
|file?": ":"",
> =A0 =A0 =A0 =A0 =A0 =A0 base);
> =A0 =A0 if (base !=3D enomem) free(base);
> =A0 =A0 errno =3D esave;
>



--=20
Zhou Peng
Operating System Technology Group
Institute of Software, the Chinese Academy of Sciences (ISCAS)