From: Shriram Rajagopalan <rshriram@cs.ubc.ca>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Brendan Cully <brendan@cs.ubc.ca>, xen-devel@lists.xensource.com
Subject: Re: [PATCH 3 of 3] remus: handle exceptions while installing/unstalling net buffer
Date: Tue, 21 Jun 2011 14:43:39 -0400 [thread overview]
Message-ID: <BANLkTimAwsQ9w3ZXD3nnAty4mwAwH4vtVg@mail.gmail.com> (raw)
In-Reply-To: <19968.53138.564453.916057@mariner.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 498 bytes --]
On Tue, Jun 21, 2011 at 1:06 PM, Ian Jackson <Ian.Jackson@eu.citrix.com>wrote:
> Brendan Cully writes ("Re: [Xen-devel] [PATCH 3 of 3] remus: handle
> exceptions while installing/unstalling net buffer"):
> > Bare except clauses are bad style. Please only handle the exact
> > exceptions you are expecting.
> >
> > Nacked-by: Brendan Cully <brendan@cs.ubc.ca>
>
> I agree. Shriram ?
>
> Ian.
>
> Yes, I ve been meaning to send out the revised version for a while. Will
send it out today.
shriram
[-- Attachment #1.2: Type: text/html, Size: 915 bytes --]
[-- Attachment #2: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2011-06-21 18:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 11:51 [PATCH 0 of 3] remus: cleanup python code Shriram Rajagopalan
2011-06-06 11:51 ` [PATCH 1 of 3] remus: remove dead code and unused modules Shriram Rajagopalan
2011-06-06 11:51 ` [PATCH 2 of 3] remus: move makeheader from image.py to vm.py Shriram Rajagopalan
2011-06-06 11:51 ` [PATCH 3 of 3] remus: handle exceptions while installing/unstalling net buffer Shriram Rajagopalan
2011-06-07 19:27 ` Brendan Cully
2011-06-21 17:06 ` Ian Jackson
2011-06-21 18:43 ` Shriram Rajagopalan [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-06-22 13:37 [PATCH 0 of 3] [Resend v2] remus: cleanup python code Shriram Rajagopalan
2011-06-22 13:37 ` [PATCH 3 of 3] remus: handle exceptions while installing/unstalling net buffer Shriram Rajagopalan
2011-06-23 15:32 ` Shriram Rajagopalan
2011-06-27 14:19 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimAwsQ9w3ZXD3nnAty4mwAwH4vtVg@mail.gmail.com \
--to=rshriram@cs.ubc.ca \
--cc=Ian.Jackson@eu.citrix.com \
--cc=brendan@cs.ubc.ca \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).