From: Wei Liu <liuw@liuw.name>
To: Keir Fraser <keir.xen@gmail.com>
Cc: xen-devel@lists.xensource.com,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH 0/2] x86: Enabling emulated MSI injection
Date: Thu, 26 May 2011 13:05:45 +0800 [thread overview]
Message-ID: <BANLkTimQT4mtwpf911OJWb6FQUDPf=vGYQ@mail.gmail.com> (raw)
In-Reply-To: <CA039A72.1B18A%keir.xen@gmail.com>
On Thu, May 26, 2011 at 12:49 PM, Keir Fraser <keir.xen@gmail.com> wrote:
> On 26/05/2011 04:06, "Wei Liu" <liuw@liuw.name> wrote:
>
>> This patch series enables Xen to deliver emulated MSI for upstream QEMU.
>>
>> To achieve this goal, a new HVM operation -- HVMOP_inj_msi -- is
>> added. Also the VMSI handling code for x86 is refactored. Libxc is
>> modified as well.
>>
>> Tested with VirtIO net and VirtIO disk.
>>
>> Signed-off-by: Wei Liu <liuw@liuw.name>
>
> Don't renumber existing HVMOPs, some of the numbers are baked into our guest
> ABI. Define your new HVMOP at the end, and enclose in if defined(__XEN__) ||
> defined(__XEN_TOOLS__) -- it is only used by toolstack (qemu) and this gives
> us flexibility to change your new interface in future if we need to, as this
> tells us it is not baked into the guest ABI.
>
Oops... I mistaken that it should go into the guest ABI. Change it later.
> Apart from that, collect an Ack from Stefano that this integrates okay with
> his pirq/emuirq stuff for delivering HVM interrupts on event channels. It
> may be that you're going in at a slightly too raw level. Stefano wrote a
> bunch of the pirq stuff so he can advise on that.
>
> -- Keir
>
>
>
OK. Waiting for his reply.
--
Best regards
Wei Liu
Twitter: @iliuw
Site: http://liuw.name
prev parent reply other threads:[~2011-05-26 5:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 3:06 [PATCH 0/2] x86: Enabling emulated MSI injection Wei Liu
2011-05-26 4:49 ` Keir Fraser
2011-05-26 5:05 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTimQT4mtwpf911OJWb6FQUDPf=vGYQ@mail.gmail.com' \
--to=liuw@liuw.name \
--cc=keir.xen@gmail.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).