xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] x86: Enabling emulated MSI injection
@ 2011-05-26  3:06 Wei Liu
  2011-05-26  4:49 ` Keir Fraser
  0 siblings, 1 reply; 3+ messages in thread
From: Wei Liu @ 2011-05-26  3:06 UTC (permalink / raw)
  To: xen-devel; +Cc: Stefano Stabellini

This patch series enables Xen to deliver emulated MSI for upstream QEMU.

To achieve this goal, a new HVM operation -- HVMOP_inj_msi -- is
added. Also the VMSI handling code for x86 is refactored. Libxc is
modified as well.

Tested with VirtIO net and VirtIO disk.

Signed-off-by: Wei Liu <liuw@liuw.name>

-- 
Best regards
Wei Liu
Twitter: @iliuw
Site: http://liuw.name

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 0/2] x86: Enabling emulated MSI injection
  2011-05-26  3:06 [PATCH 0/2] x86: Enabling emulated MSI injection Wei Liu
@ 2011-05-26  4:49 ` Keir Fraser
  2011-05-26  5:05   ` Wei Liu
  0 siblings, 1 reply; 3+ messages in thread
From: Keir Fraser @ 2011-05-26  4:49 UTC (permalink / raw)
  To: Wei Liu, xen-devel; +Cc: Stefano Stabellini

On 26/05/2011 04:06, "Wei Liu" <liuw@liuw.name> wrote:

> This patch series enables Xen to deliver emulated MSI for upstream QEMU.
> 
> To achieve this goal, a new HVM operation -- HVMOP_inj_msi -- is
> added. Also the VMSI handling code for x86 is refactored. Libxc is
> modified as well.
> 
> Tested with VirtIO net and VirtIO disk.
> 
> Signed-off-by: Wei Liu <liuw@liuw.name>

Don't renumber existing HVMOPs, some of the numbers are baked into our guest
ABI. Define your new HVMOP at the end, and enclose in if defined(__XEN__) ||
defined(__XEN_TOOLS__) -- it is only used by toolstack (qemu) and this gives
us flexibility to change your new interface in future if we need to, as this
tells us it is not baked into the guest ABI.

Apart from that, collect an Ack from Stefano that this integrates okay with
his pirq/emuirq stuff for delivering HVM interrupts on event channels. It
may be that you're going in at a slightly too raw level. Stefano wrote a
bunch of the pirq stuff so he can advise on that.

 -- Keir

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 0/2] x86: Enabling emulated MSI injection
  2011-05-26  4:49 ` Keir Fraser
@ 2011-05-26  5:05   ` Wei Liu
  0 siblings, 0 replies; 3+ messages in thread
From: Wei Liu @ 2011-05-26  5:05 UTC (permalink / raw)
  To: Keir Fraser; +Cc: xen-devel, Stefano Stabellini

On Thu, May 26, 2011 at 12:49 PM, Keir Fraser <keir.xen@gmail.com> wrote:
> On 26/05/2011 04:06, "Wei Liu" <liuw@liuw.name> wrote:
>
>> This patch series enables Xen to deliver emulated MSI for upstream QEMU.
>>
>> To achieve this goal, a new HVM operation -- HVMOP_inj_msi -- is
>> added. Also the VMSI handling code for x86 is refactored. Libxc is
>> modified as well.
>>
>> Tested with VirtIO net and VirtIO disk.
>>
>> Signed-off-by: Wei Liu <liuw@liuw.name>
>
> Don't renumber existing HVMOPs, some of the numbers are baked into our guest
> ABI. Define your new HVMOP at the end, and enclose in if defined(__XEN__) ||
> defined(__XEN_TOOLS__) -- it is only used by toolstack (qemu) and this gives
> us flexibility to change your new interface in future if we need to, as this
> tells us it is not baked into the guest ABI.
>

Oops... I mistaken that it should go into the guest ABI. Change it later.

> Apart from that, collect an Ack from Stefano that this integrates okay with
> his pirq/emuirq stuff for delivering HVM interrupts on event channels. It
> may be that you're going in at a slightly too raw level. Stefano wrote a
> bunch of the pirq stuff so he can advise on that.
>
>  -- Keir
>
>
>

OK. Waiting for his reply.

-- 
Best regards
Wei Liu
Twitter: @iliuw
Site: http://liuw.name

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-05-26  5:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-26  3:06 [PATCH 0/2] x86: Enabling emulated MSI injection Wei Liu
2011-05-26  4:49 ` Keir Fraser
2011-05-26  5:05   ` Wei Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).