Re: Fwd:[PATCH-may be a bug ignored] tools/libxl/libxl__build_device_model_args_new/old: The condition is so rigorous that user has no chance to disable the vnc

[ZhouPeng <zpengxen@gmail.com>]

Thanks.

2011/4/20 Stefano Stabellini <stefano.stabellini@eu.citrix.com>:
> On Wed, 20 Apr 2011, ZhouPeng wrote:
>> In my spice testing,
>> I find user have no way to disable vnc in qemu-old and new using xl,
>> no matter how to set
>> "vnc vncunused vncpasswd vncdisplay vnclisten" in vm cfg file.
>>
>> I think this may be a bug ignored.
>>
>> Signed-off-by: Zhou Peng <zhoupeng@nfs.iscas.ac.cn>
>>
>> tools/libxl/libxl__build_device_model_args_new/old: The condition is
>> so rigorous that user has no chance to disable the vnc,
>> considering what has been done in parse_config_data() by default,
>> which is not resonable with vnc option in vm-cfg file.
>>
>> I think, If user explicitly set "vnc=0", vnc should be disabled.
>> User should have the chance to only use sdl, other remote
>> display(spice) and even nothing.
>>
>
>
> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
>



-- 
Zhou Peng
Operating System Technology Group
Institute of Software, the Chinese Academy of Sciences (ISCAS)