From mboxrd@z Thu Jan 1 00:00:00 1970 From: ZhouPeng Subject: Re: Fwd:[PATCH-may be a bug ignored] tools/libxl/libxl__build_device_model_args_new/old: The condition is so rigorous that user has no chance to disable the vnc Date: Thu, 21 Apr 2011 09:02:16 +0800 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Stefano Stabellini Cc: "Xen-Devel (E-mail)" , Ian Jackson List-Id: xen-devel@lists.xenproject.org Thanks. 2011/4/20 Stefano Stabellini : > On Wed, 20 Apr 2011, ZhouPeng wrote: >> In my spice testing, >> I find user have no way to disable vnc in qemu-old and new using xl, >> no matter how to set >> "vnc vncunused vncpasswd vncdisplay vnclisten" in vm cfg file. >> >> I think this may be a bug ignored. >> >> Signed-off-by: Zhou Peng >> >> tools/libxl/libxl__build_device_model_args_new/old: The condition is >> so rigorous that user has no chance to disable the vnc, >> considering what has been done in parse_config_data() by default, >> which is not resonable with vnc option in vm-cfg file. >> >> I think, If user explicitly set "vnc=0", vnc should be disabled. >> User should have the chance to only use sdl, other remote >> display(spice) and even nothing. >> > > > Acked-by: Stefano Stabellini > > -- Zhou Peng Operating System Technology Group Institute of Software, the Chinese Academy of Sciences (ISCAS)