From: Shriram Rajagopalan <rshriram@cs.ubc.ca>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Jim Fehlig <jfehlig@novell.com>, xen-devel@lists.xensource.com
Subject: Re: [PATCH 0 of 8] Remove static variables from xc_domain_{save, restore}.c
Date: Tue, 24 May 2011 09:47:35 -0400 [thread overview]
Message-ID: <BANLkTimp6NToYCX8q-Nfkd+eGJvuxEmt-Q@mail.gmail.com> (raw)
In-Reply-To: <patchbomb.1306228466@cosworth.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 1337 bytes --]
On Tue, May 24, 2011 at 5:14 AM, Ian Campbell <ian.campbell@citrix.com>wrote:
> Otherwise users which deal with multiple domains need to do their own
> locking and cannot save/migrate multiple domains in parallel (should
> they want to).
>
> Also made a bunch of cleanup along the way, mainly to make it easier
> to figure out what was going on with the twisty maze of macros
> redefining functions as macros and redefining the macros etc. I'm sure
> there is plenty more straightening out which could be done but I don't
> have the stomach for it this morning.
>
> I ll do it!!.. I have been waiting for this. Thanks a lot for cleaning up
this chaff!
I was under the impression that this was some arcane legacy code that
shouldnt
be touched. One particular thing that I would like to do is to factor out
the write functions
(outbuf_*, noncached_write, ratewrite*, etc) into a separate file and make
it sort of pluggable.
(selfish :P) I wanted to introduce a patch that would overlap outbuf flush
operation
and guest memory copy operation instead of the current model
<flush,copy,flush,copy..>.
This might be helpful for both Remus and live migration of large domains.
Shriram, does this have any impact on Remus?
>
> From a cursory look, it doesnt look like it would impact Remus. I ll test
it
in my setup and revert soon.
shriram
[-- Attachment #1.2: Type: text/html, Size: 1847 bytes --]
[-- Attachment #2: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2011-05-24 13:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 9:14 [PATCH 0 of 8] Remove static variables from xc_domain_{save, restore}.c Ian Campbell
2011-05-24 9:14 ` [PATCH 1 of 8] libxc: save/restore: remove static context variables Ian Campbell
2011-05-24 10:33 ` Vincent Hanquez
2011-05-24 9:14 ` [PATCH 2 of 8] libxc: save: drop code under ADAPTIVE_SAVE ifdef Ian Campbell
2011-05-24 9:14 ` [PATCH 3 of 8] libxc: save: rename ratewrite to uncached Ian Campbell
2011-05-24 9:14 ` [PATCH 4 of 8] libxc: save: noncached write doesn't use live parameter Ian Campbell
2011-05-24 9:14 ` [PATCH 5 of 8] libxc: save: move static "write_count" variable into outbuf Ian Campbell
2011-05-24 9:14 ` [PATCH 6 of 8] libxc: save: encapsulate time stats in a struct Ian Campbell
2011-05-24 9:14 ` [PATCH 7 of 8] libxc: save: don't bother calculating stat's deltas unless we are going to print them Ian Campbell
2011-05-24 9:14 ` [PATCH 8 of 8] libxc: save: move static stats variable to stack variable Ian Campbell
2011-05-24 16:45 ` Ian Jackson
2011-05-24 13:47 ` Shriram Rajagopalan [this message]
2011-05-24 17:02 ` [PATCH 0 of 8] Remove static variables from xc_domain_{save, restore}.c Ian Jackson
2011-05-24 17:52 ` Ian Campbell
2011-05-24 18:57 ` Shriram Rajagopalan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimp6NToYCX8q-Nfkd+eGJvuxEmt-Q@mail.gmail.com \
--to=rshriram@cs.ubc.ca \
--cc=ian.campbell@citrix.com \
--cc=jfehlig@novell.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).