From mboxrd@z Thu Jan 1 00:00:00 1970 From: ZhouPeng Subject: Re: Fwd:[PATCH-may be a bug ignored] tools/libxl/libxl__build_device_model_args_new/old: The condition is so rigorous that user has no chance to disable the vnc Date: Tue, 10 May 2011 19:09:32 +0800 Message-ID: References: <19911.57349.743943.518422@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: "Xen-Devel (E-mail)" , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org 2011/5/10 ZhouPeng : > 2011/5/9 Ian Jackson : >> ZhouPeng writes ("[Xen-devel] Fwd:[PATCH-may be a bug ignored] tools/lib= xl/libxl__build_device_model_args_new/old: The condition is so rigorous tha= t user has no chance to disable the vnc"): >>> In my spice testing, >>> I find user have no way to disable vnc in qemu-old and new using xl, >>> no matter how to set >>> "vnc vncunused vncpasswd vncdisplay vnclisten" in vm cfg file. >> >> Does your patch not have the effect of turning vnc off by default ? =A0I >> don't think that's correct. > > pls see below: > parse_config_data(...) =A0< xl_cmdimpl.c > > =A0 =A0 =A0 libxl_init_dm_info(...) set dm_info->vnc =3D 1 > =A0 =A0 =A0 ... > =A0 =A0 =A0 if (!xlu_cfg_get_long(config, "vnc", &l)) > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0dm_info->vnc =3D l > > So, The patch will not turn vnc off =A0by default, So, The patch will not turn vnc off by default. ...typo mistake :) > Because dm_info->vnc =3D 1 in libxl_init_dm_info(...) turn on vnc in defa= ult, > My patch turns off vnc only when user 'set vnc =3D 0' explicitly in vm cf= g file. > > And testing in xen-unstable, it works. > > Thanks, >> Ian. >> > > > > -- > Zhou Peng > Operating System Technology Group > Institute of Software, the Chinese Academy of Sciences (ISCAS) > --=20 Zhou Peng Operating System Technology Group Institute of Software, the Chinese Academy of Sciences (ISCAS)