xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: ZhouPeng <zpengxen@gmail.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "Xen-Devel (E-mail)" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] tool/libxl: mistake apic for acpi in libxl__build_device_model_args_old/new
Date: Tue, 19 Apr 2011 13:14:05 +0800	[thread overview]
Message-ID: <BANLkTinN6G5j3v5FL=dYLsijqyg7LocgLg@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1104181450240.10886@kaball-desktop>

Thanks.

2011/4/18 Stefano Stabellini <stefano.stabellini@eu.citrix.com>:
> On Fri, 15 Apr 2011, ZhouPeng wrote:
>> Signed-off-by: Zhou Peng <zhoupeng@nfs.iscas.ac.cn>
>>
>> tool/libxl: mistake apic for acpi in libxl__build_device_model_args_old/new
>>
>
> this patch should be applied ASAP and backported to 4.1.
>
>
>> diff -r 6871474a2a09 -r 01f8b29dda8e tools/libxl/libxl_dm.c
>> --- a/tools/libxl/libxl_dm.c    Fri Apr 15 10:06:59 2011 +0800
>> +++ b/tools/libxl/libxl_dm.c    Fri Apr 15 15:17:42 2011 +0800
>> @@ -120,7 +120,7 @@ static char ** libxl__build_device_model
>>          if (info->soundhw) {
>>              flexarray_vappend(dm_args, "-soundhw", info->soundhw, NULL);
>>          }
>> -        if (info->apic) {
>> +        if (info->acpi) {
>>              flexarray_append(dm_args, "-acpi");
>>          }
>>          if (info->vcpus > 1) {
>> @@ -268,7 +268,7 @@ static char ** libxl__build_device_model
>>          if (info->soundhw) {
>>              flexarray_vappend(dm_args, "-soundhw", info->soundhw, NULL);
>>          }
>> -        if (!info->apic) {
>> +        if (!info->acpi) {
>>              flexarray_append(dm_args, "-no-acpi");
>>          }
>>          if (info->vcpus > 1) {
>>
>> --
>> Zhou Peng
>> Operating System Technology Group
>> Institute of Software, the Chinese Academy of Sciences (ISCAS)
>>
>>
>>



-- 
Zhou Peng
Operating System Technology Group
Institute of Software, the Chinese Academy of Sciences (ISCAS)

  reply	other threads:[~2011-04-19  5:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-15  8:41 [PATCH] tool/libxl: mistake apic for acpi in libxl__build_device_model_args_old/new ZhouPeng
2011-04-18 13:50 ` Stefano Stabellini
2011-04-19  5:14   ` ZhouPeng [this message]
2011-05-09  8:20 ` Ian Jackson
2011-05-09  9:10   ` Ian Campbell
2011-05-10 12:07   ` ZhouPeng
2011-05-10 12:23     ` Ian Campbell
2011-05-11  2:11       ` ZhouPeng
2011-05-17 16:28         ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTinN6G5j3v5FL=dYLsijqyg7LocgLg@mail.gmail.com' \
    --to=zpengxen@gmail.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).