From mboxrd@z Thu Jan  1 00:00:00 1970
From: ZhouPeng <zpengxen@gmail.com>
Subject: Re: [PATCH] tool/libxl: mistake apic for acpi in
	libxl__build_device_model_args_old/new
Date: Tue, 19 Apr 2011 13:14:05 +0800
Message-ID: <BANLkTinN6G5j3v5FL=dYLsijqyg7LocgLg@mail.gmail.com>
References: <BANLkTikHD2HOYzzV0ci6TBF5=tVSau6zfg@mail.gmail.com>
	<alpine.DEB.2.00.1104181450240.10886@kaball-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <alpine.DEB.2.00.1104181450240.10886@kaball-desktop>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "Xen-Devel (E-mail)" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Thanks.

2011/4/18 Stefano Stabellini <stefano.stabellini@eu.citrix.com>:
> On Fri, 15 Apr 2011, ZhouPeng wrote:
>> Signed-off-by: Zhou Peng <zhoupeng@nfs.iscas.ac.cn>
>>
>> tool/libxl: mistake apic for acpi in libxl__build_device_model_args_old/=
new
>>
>
> this patch should be applied ASAP and backported to 4.1.
>
>
>> diff -r 6871474a2a09 -r 01f8b29dda8e tools/libxl/libxl_dm.c
>> --- a/tools/libxl/libxl_dm.c=A0=A0=A0 Fri Apr 15 10:06:59 2011 +0800
>> +++ b/tools/libxl/libxl_dm.c=A0=A0=A0 Fri Apr 15 15:17:42 2011 +0800
>> @@ -120,7 +120,7 @@ static char ** libxl__build_device_model
>> =A0=A0=A0=A0=A0=A0=A0=A0 if (info->soundhw) {
>> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 flexarray_vappend(dm_args, "-soundh=
w", info->soundhw, NULL);
>> =A0=A0=A0=A0=A0=A0=A0=A0 }
>> -=A0=A0=A0=A0=A0=A0=A0 if (info->apic) {
>> +=A0=A0=A0=A0=A0=A0=A0 if (info->acpi) {
>> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 flexarray_append(dm_args, "-acpi");
>> =A0=A0=A0=A0=A0=A0=A0=A0 }
>> =A0=A0=A0=A0=A0=A0=A0=A0 if (info->vcpus > 1) {
>> @@ -268,7 +268,7 @@ static char ** libxl__build_device_model
>> =A0=A0=A0=A0=A0=A0=A0=A0 if (info->soundhw) {
>> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 flexarray_vappend(dm_args, "-soundh=
w", info->soundhw, NULL);
>> =A0=A0=A0=A0=A0=A0=A0=A0 }
>> -=A0=A0=A0=A0=A0=A0=A0 if (!info->apic) {
>> +=A0=A0=A0=A0=A0=A0=A0 if (!info->acpi) {
>> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 flexarray_append(dm_args, "-no-acpi=
");
>> =A0=A0=A0=A0=A0=A0=A0=A0 }
>> =A0=A0=A0=A0=A0=A0=A0=A0 if (info->vcpus > 1) {
>>
>> --
>> Zhou Peng
>> Operating System Technology Group
>> Institute of Software, the Chinese Academy of Sciences (ISCAS)
>>
>>
>>



--=20
Zhou Peng
Operating System Technology Group
Institute of Software, the Chinese Academy of Sciences (ISCAS)